linux-kernel - Re: [PATCH v2 05/12] arm64: dts: marvell: armada-3720-db: add comphy references

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210211233136.t36ytezz4n6lbtmn@pali>
Date:   Fri, 12 Feb 2021 00:31:36 +0100
From:   Pali Rohár <pali@...nel.org>
To:     kostap@...vell.com
Cc:     linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux@...linux.org.uk,
        robh+dt@...nel.org, sebastian.hesselbarth@...il.com,
        gregory.clement@...tlin.com, andrew@...n.ch, mw@...ihalf.com,
        jaz@...ihalf.com, nadavh@...vell.com, stefanc@...vell.com,
        bpeled@...vell.com
Subject: Re: [PATCH v2 05/12] arm64: dts: marvell: armada-3720-db: add comphy
 references

On Wednesday 10 February 2021 16:09:42 kostap@...vell.com wrote:
> From: Grzegorz Jaszczyk <jaz@...ihalf.com>
> 
> Adding phy description to pcie, sata and usb will allow appropriate drivers
> to configure marvell comphy-a3700 accordingly.
> 
> Signed-off-by: Grzegorz Jaszczyk <jaz@...ihalf.com>
> Signed-off-by: Konstantin Porotchkin <kostap@...vell.com>

Hello! This patch is not needed too as Gregory already included into his
tree alternative patch which defines SATA PHY globally into main include
file armada-37xx.dtsi:

https://git.kernel.org/pub/scm/linux/kernel/git/gclement/mvebu.git/commit/?h=for-next&id=6ece0f7dbd558670ec72ba390379949a4d4dc5c0

And PCIe and USB 3.0 PHY definitions are already in include file.

> ---
>  arch/arm64/boot/dts/marvell/armada-3720-db.dts | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-db.dts b/arch/arm64/boot/dts/marvell/armada-3720-db.dts
> index 3e5789f37206..15e923f945d4 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-db.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-db.dts
> @@ -132,11 +132,15 @@
>  	pinctrl-0 = <&pcie_reset_pins &pcie_clkreq_pins>;
>  	reset-gpios = <&gpiosb 3 GPIO_ACTIVE_LOW>;
>  	status = "okay";
> +	/* Generic PHY, providing serdes lanes */
> +	phys = <&comphy1 0>;
>  };
>  
>  /* CON3 */
>  &sata {
>  	status = "okay";
> +	/* Generic PHY, providing serdes lanes */
> +	phys = <&comphy2 0>;
>  };
>  
>  &sdhci0 {
> @@ -217,4 +221,7 @@
>  &usb3 {
>  	status = "okay";
>  	usb-phy = <&usb3_phy>;
> +	/* Generic PHY, providing serdes lanes */
> +	phys = <&comphy0 0>;
> +	phy-names = "usb";
>  };
> -- 
> 2.17.1
>