linux-kernel - Re: [PATCH v2 06/12] arm64: dts: marvell: armada-3270-espressobin: add comphy references

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210211232842.no4jhvdwh4634cyt@pali>
Date:   Fri, 12 Feb 2021 00:28:42 +0100
From:   Pali Rohár <pali@...nel.org>
To:     kostap@...vell.com
Cc:     linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux@...linux.org.uk,
        robh+dt@...nel.org, sebastian.hesselbarth@...il.com,
        gregory.clement@...tlin.com, andrew@...n.ch, mw@...ihalf.com,
        jaz@...ihalf.com, nadavh@...vell.com, stefanc@...vell.com,
        bpeled@...vell.com
Subject: Re: [PATCH v2 06/12] arm64: dts: marvell: armada-3270-espressobin:
 add comphy references

On Wednesday 10 February 2021 16:09:43 kostap@...vell.com wrote:
> From: Grzegorz Jaszczyk <jaz@...ihalf.com>
> 
> Add "phys" entries pointing to COMPHYs to PCIe and USB3 nodes
> 
> Signed-off-by: Grzegorz Jaszczyk <jaz@...ihalf.com>
> Signed-off-by: Konstantin Porotchkin <kostap@...vell.com>

Hello! This patch is not needed and now does nothing.

> ---
>  arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi
> index daffe136c523..bbd955909813 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi
> @@ -59,6 +59,8 @@
>  /* J9 */
>  &pcie0 {
>  	status = "okay";
> +	/* Generic PHY, providing serdes lanes */
> +	phys = <&comphy1 0>;

In mainline kernel is PCIe PHY already provided in armada-37xx.dtsi:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/marvell/armada-37xx.dtsi#n497

>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pcie_reset_pins &pcie_clkreq_pins>;
>  	reset-gpios = <&gpiosb 3 GPIO_ACTIVE_LOW>;
> @@ -139,6 +141,9 @@
>  /* J7 */
>  &usb3 {
>  	status = "okay";
> +	/* Generic PHY, providing serdes lanes */
> +	phys = <&comphy0 0>;
> +	phy-names = "usb";

In mainline kernel is USB 3.0 PHY already provided in armada-37xx.dtsi:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/marvell/armada-37xx.dtsi#n359

>  };
>  
>  /* J8 */
> -- 
> 2.17.1
> 

So final binary espressobin DTB files are same with and without this
patch.