linux-kernel - Re: [PATCH v8 1/4] KEYS: trusted: Add generic trusted keys framework

Open Source and information security mailing list archives

Message-ID: <f51409f7-05b4-31b6-f1c5-d9e6d7c0bb46@pengutronix.de>
Date:   Thu, 11 Feb 2021 11:34:21 +0100
From:   Ahmad Fatoum <a.fatoum@...gutronix.de>
To:     Jarkko Sakkinen <jarkko@...nel.org>,
        Sumit Garg <sumit.garg@...aro.org>
Cc:     linux-security-module@...r.kernel.org, daniel.thompson@...aro.org,
        op-tee@...ts.trustedfirmware.org, corbet@....net,
        jejb@...ux.ibm.com, janne.karhunen@...il.com,
        linux-doc@...r.kernel.org, jmorris@...ei.org, zohar@...ux.ibm.com,
        linux-kernel@...r.kernel.org, dhowells@...hat.com,
        lhinds@...hat.com, keyrings@...r.kernel.org,
        jarkko.sakkinen@...ux.intel.com, Markus.Wamser@...ed-mode.de,
        casey@...aufler-ca.com, linux-integrity@...r.kernel.org,
        jens.wiklander@...aro.org, linux-arm-kernel@...ts.infradead.org,
        serge@...lyn.com
Subject: Re: [PATCH v8 1/4] KEYS: trusted: Add generic trusted keys framework

Hello Jarkko,

On 10.02.21 18:00, Jarkko Sakkinen wrote:
> On Tue, Nov 03, 2020 at 09:31:43PM +0530, Sumit Garg wrote:
>> +	case Opt_new:
>> +		key_len = payload->key_len;
>> +		ret = static_call(trusted_key_get_random)(payload->key,
>> +							  key_len);
>> +		if (ret != key_len) {
>> +			pr_info("trusted_key: key_create failed (%d)\n", ret);
>> +			goto out;
>> +		}
> 
> This repeats a regression in existing code, i.e. does not check
> "ret < 0" condition. I noticed this now when I rebased the code
> on top of my fixes.
> 
> I.e. it's fixed in my master branch, which caused a merge conflict,
> and I found this.

Does that mean this series will go out for the next merge window?
Can you point me where your git tree is, so I can rebase on top?

> 
> /Jarkko
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives