linux-kernel - This reply comments on the patch to fixes the missing a blank line warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bce53689-4a6e-c3c3-a09c-6e946a577f61@redhat.com>
Date:   Thu, 11 Feb 2021 11:36:58 +0100
From:   David Hildenbrand <david@...hat.com>
To:     Adithya Chandrakasan <adithya.chandrakasan@...il.com>,
        akpm@...ux-foundation.org
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        skhan@...uxfoundation.org
Subject: This reply comments on the patch to fixes the missing a blank line
 warning

^

Please create proper patch subjects. Nobody has a glue what you are 
doing when looking at the subject.

"mm/util: fix ??? warning"

Which raises the question, what is ???

Compiler? static code checker? ... ?


Thanks

On 11.02.21 08:29, Adithya Chandrakasan wrote:
> FILE: mm/util.c:930: WARNING: Missing a blank line after declarations
> 
> Signed-off-by: Adithya Chandrakasan <adithya.chandrakasan@...il.com>
> ---
>   mm/util.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/mm/util.c b/mm/util.c
> index 8c9b7d1e7c49..60286876636d 100644
> --- a/mm/util.c
> +++ b/mm/util.c
> @@ -927,6 +927,7 @@ int get_cmdline(struct task_struct *task, char *buffer, int buflen)
>   	unsigned int len;
>   	struct mm_struct *mm = get_task_mm(task);
>   	unsigned long arg_start, arg_end, env_start, env_end;
> +
>   	if (!mm)
>   		goto out;
>   	if (!mm->arg_end)
> 


-- 
Thanks,

David / dhildenb