linux-kernel - Re: [PATCH v5 04/15] PCI: Add pci_find_vsec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YCUoJuK8TBsJAnp7@rocinante>
Date:   Thu, 11 Feb 2021 13:50:46 +0100
From:   Krzysztof Wilczyński <kw@...ux.com>
To:     Gustavo Pimentel <Gustavo.Pimentel@...opsys.com>
Cc:     dmaengine@...r.kernel.org, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org, Vinod Koul <vkoul@...nel.org>,
        Dan Williams <dan.j.williams@...el.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>
Subject: Re: [PATCH v5 04/15] PCI: Add pci_find_vsec_capability() to find a
 specific VSEC

Hi Gustavo,

[...]
> + * Typically this function will be called by the pci driver, which passes

It would be "PCI" here.

> + * through argument the 'struct pci_dev *' already pointing for the device
> + * config space that is associated with the vendor and device ID which will
> + * know which ID to search and what to do with it, however, it might be

Probably "there might be".

> + * cases that this function could be called outside of this scope and
> + * therefore is the caller responsibility to check the vendor and/or
[...]

A suggestion.  This commit message is a little hard to read and could be
improved.

It might just be me (by and large, and I am not a native English
speaker), but it's actually easier to figure out what the function does
after reading the implementation that from the comment. :)

Krzysztof