linux-kernel - Re: [PATCH v5 05/15] dmaengine: dw-edma: Add PCIe VSEC data retrieval support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YCUqRCw1QQD8wa//@rocinante>
Date:   Thu, 11 Feb 2021 13:59:48 +0100
From:   Krzysztof Wilczyński <kw@...ux.com>
To:     Gustavo Pimentel <Gustavo.Pimentel@...opsys.com>
Cc:     dmaengine@...r.kernel.org, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org, Vinod Koul <vkoul@...nel.org>,
        Dan Williams <dan.j.williams@...el.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>
Subject: Re: [PATCH v5 05/15] dmaengine: dw-edma: Add PCIe VSEC data
 retrieval support

Hi Gustavo,

> +	/*
> +	 * Tries to find if exists a PCIe Vendor-Specific Extended Capability
> +	 * for the DMA, if exists one, then reconfigures with the new data
[...]

What about "if one exists" and "then reconfigures it".  Missing period
at the end of the sentence.

Krzysztof