linux-kernel - RE: [PATCH v5 05/15] dmaengine: dw-edma: Add PCIe VSEC data retrieval support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM5PR12MB18358FC8B24C263AABB081B7DA8C9@DM5PR12MB1835.namprd12.prod.outlook.com>
Date:   Thu, 11 Feb 2021 13:48:42 +0000
From:   Gustavo Pimentel <Gustavo.Pimentel@...opsys.com>
To:     Krzysztof Wilczyński <kw@...ux.com>
CC:     "dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Vinod Koul <vkoul@...nel.org>,
        Dan Williams <dan.j.williams@...el.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>
Subject: RE: [PATCH v5 05/15] dmaengine: dw-edma: Add PCIe VSEC data retrieval
 support

On Thu, Feb 11, 2021 at 12:59:48, Krzysztof Wilczyński <kw@...ux.com> 
wrote:

> Hi Gustavo,
> 
> > +	/*
> > +	 * Tries to find if exists a PCIe Vendor-Specific Extended Capability
> > +	 * for the DMA, if exists one, then reconfigures with the new data
> [...]
> 
> What about "if one exists" and "then reconfigures it".  Missing period
> at the end of the sentence.

That would be better. Thanks.

> 
> Krzysztof