linux-kernel - RE: [PATCH net-next v2] misc: Add Renesas Synchronization Management Unit (SMU) support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 12 Feb 2021 19:06:17 +0000
From:   Min Li <min.li.xe@...esas.com>
To:     Greg KH <gregkh@...uxfoundation.org>
CC:     "derek.kiernan@...inx.com" <derek.kiernan@...inx.com>,
        "dragan.cvetic@...inx.com" <dragan.cvetic@...inx.com>,
        "arnd@...db.de" <arnd@...db.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH net-next v2] misc: Add Renesas Synchronization Management
 Unit (SMU) support

> 
> On Fri, Feb 12, 2021 at 03:44:52PM +0000, Min Li wrote:
> > > >
> > > > -set combomode
> > > > -get dpll's state
> > > > -get dpll's ffo
> > > >
> > > > This driver must work with Renesas MFD driver to access SMU
> > > > through I2C/SPI.
> > > >
> > > > Changes since v1:
> > > > -Provide more background for purpose of the change.
> > > > -Provide compat_ioctl support
> > > > -Fix ioctl cmd definition
> > >
> > > This "changes" list goes below the --- line.
> > >
> >
> > Sorry, is this a problem that you are requesting me to address? I am bit
> confused...
> 
> Yes, please place that list of changes below the --- line in your patch.
> The documentation says to do this, right?
> 
Hi Greg

Do you mean this "---" like below? How can I do that? Sorry I was never asked to do that from other reviewer.

Signed-off-by: Min Li <min.li.xe@...esas.com>
---
 drivers/misc/Kconfig      |  13 ++
 drivers/misc/Makefile     |   3 +
 drivers/misc/rsmu_cdev.c  | 449 ++++++++++++++++++++++++++++++++++++++++++++++
 drivers/misc/rsmu_cdev.h  |  75 ++++++++
 drivers/misc/rsmu_cm.c    | 214 ++++++++++++++++++++++
 drivers/misc/rsmu_sabre.c | 153 ++++++++++++++++
 include/uapi/linux/rsmu.h |  61 +++++++
 7 files changed, 968 insertions(+)
 create mode 100644 drivers/misc/rsmu_cdev.c
 create mode 100644 drivers/misc/rsmu_cdev.h
 create mode 100644 drivers/misc/rsmu_cm.c
 create mode 100644 drivers/misc/rsmu_sabre.c
 create mode 100644 include/uapi/linux/rsmu.h