lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20210213141021.87840-11-alobakin@pm.me> Date: Sat, 13 Feb 2021 14:12:49 +0000 From: Alexander Lobakin <alobakin@...me> To: "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org> Cc: Jonathan Lemon <jonathan.lemon@...il.com>, Eric Dumazet <edumazet@...gle.com>, Dmitry Vyukov <dvyukov@...gle.com>, Willem de Bruijn <willemb@...gle.com>, Alexander Lobakin <alobakin@...me>, Randy Dunlap <rdunlap@...radead.org>, Kevin Hao <haokexin@...il.com>, Pablo Neira Ayuso <pablo@...filter.org>, Jakub Sitnicki <jakub@...udflare.com>, Marco Elver <elver@...gle.com>, Dexuan Cui <decui@...rosoft.com>, Paolo Abeni <pabeni@...hat.com>, Jesper Dangaard Brouer <brouer@...hat.com>, Alexander Duyck <alexanderduyck@...com>, Alexander Duyck <alexander.duyck@...il.com>, Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, Andrii Nakryiko <andriin@...com>, Taehee Yoo <ap420073@...il.com>, Wei Wang <weiwan@...gle.com>, Cong Wang <xiyou.wangcong@...il.com>, Björn Töpel <bjorn@...nel.org>, Miaohe Lin <linmiaohe@...wei.com>, Guillaume Nault <gnault@...hat.com>, Florian Westphal <fw@...len.de>, Edward Cree <ecree.xilinx@...il.com>, linux-kernel@...r.kernel.org, netdev@...r.kernel.org Subject: [PATCH v6 net-next 10/11] skbuff: allow to use NAPI cache from __napi_alloc_skb() {,__}napi_alloc_skb() is mostly used either for optional non-linear receive methods (usually controlled via Ethtool private flags and off by default) and/or for Rx copybreaks. Use __napi_build_skb() here for obtaining skbuff_heads from NAPI cache instead of inplace allocations. This includes both kmalloc and page frag paths. Signed-off-by: Alexander Lobakin <alobakin@...me> --- net/core/skbuff.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/net/core/skbuff.c b/net/core/skbuff.c index a80581eed7fc..875e1a453f7e 100644 --- a/net/core/skbuff.c +++ b/net/core/skbuff.c @@ -562,7 +562,8 @@ struct sk_buff *__napi_alloc_skb(struct napi_struct *napi, unsigned int len, if (len <= SKB_WITH_OVERHEAD(1024) || len > SKB_WITH_OVERHEAD(PAGE_SIZE) || (gfp_mask & (__GFP_DIRECT_RECLAIM | GFP_DMA))) { - skb = __alloc_skb(len, gfp_mask, SKB_ALLOC_RX, NUMA_NO_NODE); + skb = __alloc_skb(len, gfp_mask, SKB_ALLOC_RX | SKB_ALLOC_NAPI, + NUMA_NO_NODE); if (!skb) goto skb_fail; goto skb_success; @@ -579,7 +580,7 @@ struct sk_buff *__napi_alloc_skb(struct napi_struct *napi, unsigned int len, if (unlikely(!data)) return NULL; - skb = __build_skb(data, len); + skb = __napi_build_skb(data, len); if (unlikely(!skb)) { skb_free_frag(data); return NULL; -- 2.30.1
Powered by blists - more mailing lists