linux-kernel - Re: [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <161317480301.1254594.16648868282165823277@swboyd.mtv.corp.google.com>
Date:   Fri, 12 Feb 2021 16:06:43 -0800
From:   Stephen Boyd <sboyd@...nel.org>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     linux-kernel@...r.kernel.org,
        Ahmad Fatoum <a.fatoum@...gutronix.de>,
        Andy Gross <agross@...nel.org>,
        Avi Fishman <avifishman70@...il.com>,
        Benjamin Fair <benjaminfair@...gle.com>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Boris BREZILLON <boris.brezillon@...e-electrons.com>,
        Chen-Yu Tsai <wens@...e.org>,
        Emilio López <emilio@...pez.com.ar>,
        Fabio Estevam <festevam@...il.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Jan Kotas <jank@...ence.com>,
        Jernej Skrabec <jernej.skrabec@...l.net>,
        Jonathan Hunter <jonathanh@...dia.com>,
        linux-arm-kernel@...ts.infradead.org,
        linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org,
        linux-omap@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
        linux-tegra@...r.kernel.org, Loc Ho <lho@....com>,
        Maxime Ripard <mripard@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        Michal Simek <michal.simek@...inx.com>,
        Nancy Yuen <yuenn@...gle.com>,
        Nuvoton Technologies <tali.perry@...oton.com>,
        NXP Linux Team <linux-imx@....com>, openbmc@...ts.ozlabs.org,
        Patrick Venture <venture@...gle.com>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Peter De Schrijver <pdeschrijver@...dia.com>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Prashant Gaikwad <pgaikwad@...dia.com>,
        Rajan Vaja <rajan.vaja@...inx.com>,
        Rajeev Kumar <rajeev-dlh.kumar@...com>,
        Richard Woodruff <r-woodruff2@...com>,
        Russell King <linux@...linux.org.uk>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Shawn Guo <shawnguo@...nel.org>,
        Shiraz Hashim <shiraz.linux.kernel@...il.com>,
        Sören Brinkmann <soren.brinkmann@...inx.com>,
        Tali Perry <tali.perry1@...il.com>,
        Tero Kristo <kristo@...nel.org>,
        Thierry Reding <thierry.reding@...il.com>,
        Tomer Maimon <tmaimon77@...il.com>,
        Viresh Kumar <vireshk@...nel.org>
Subject: Re: [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock

Quoting Lee Jones (2021-02-12 14:37:39)
> On Fri, 12 Feb 2021, Stephen Boyd wrote:
> 
> > 
> > I'd like to enable it for only files under drivers/clk/ but it doesn't
> > seem to work. I'm not asking to enable it at the toplevel Makefile. I'm
> > asking to enable it for drivers/clk/ so nobody has to think about it now
> > that you've done the hard work of getting the numbers in this directory
> > down to zero or close to zero.
> 
> I'm not sure which one of us is confused.  Probably me, but ...
> 
> Even if you could enable it per-subsystem, how would that help you?
> 
> How can you ensure that contributors see any new W=1 warnings, but
> Linus doesn't?  When Linus conducts his build-tests during the merge
> window, he is also going to build W=1 for drivers/clk.

The assumption is contributors would have compiled the code they're
sending, but that's obviously not always the case, so this assumption
relies on developers running make. If they do run make then the hope is
they would see the warnings now, without having to rely on them to know
about passing W=1 to make, and fix them before sending code. If
developers are ignoring build errors or warnings then we can't do
anything anyway.

> 
> All that's going to achieve is put you in the firing line.

Ok. Is this prior experience?

> 
> From my PoV W=1 builds should be enabled during the development phase
> (i.e. contributor, auto-builder, maintainer).  By the time patches get
> make it into Mainline the review/testing stage is over and only the
> default W=0 warnings are meaningful.
> 

Alright maybe I don't understand and W=1 builds are noisy for the
drivers/clk subdirectory even after applying these patches. Or it has
some false positives that won't be fixed? Or a new compiler can cause
new warnings to happen? I could see these things being a problem.

I'm trying to see if we can make lives better for everyone by exposing
the warnings by default in the drivers/clk/ directory now that there are
supposedly none left. Shouldn't we tighten the screws now that we've
cleaned them?