linux-kernel - Re: [PATCH] lkdtm: don't move ctors to .rodata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210214223257.GA2858@sasha-vm>
Date:   Sun, 14 Feb 2021 17:32:57 -0500
From:   Sasha Levin <sashal@...nel.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Stephen Boyd <swboyd@...omium.org>,
        Kees Cook <keescook@...omium.org>,
        Mark Rutland <mark.rutland@....com>,
        linux-kernel@...r.kernel.org, Arnd Bergmann <arnd@...db.de>,
        stable@...r.kernel.org
Subject: Re: [PATCH] lkdtm: don't move ctors to .rodata

On Sun, Feb 14, 2021 at 06:16:29PM +0100, Greg Kroah-Hartman wrote:
>On Thu, Feb 11, 2021 at 10:53:10AM -0800, Stephen Boyd wrote:
>> Sorry for the confusion. Can commit 655389666643 ("vmlinux.lds.h: Create
>> section for protection against instrumentation") and commit 3f618ab33234
>> ("lkdtm: don't move ctors to .rodata") be backported to 5.4.y and only
>> commit 3f618ab3323407ee4c6a6734a37eb6e9663ebfb9 be backported to 5.10.y?
>
>655389666643 ("vmlinux.lds.h: Create section for protection against
>instrumentation") does not apply cleanly to 5.4.y, so can you provide a
>working backport for both of those patches to 5.4.y that you have
>tested?

It was due to a backport of eff8728fe698 ("vmlinux.lds.h: Add PGO and
AutoFDO input sections"). Taking 655389666643 and 3f618ab33234 converged
us back with Linus's tree as eff8728fe698 worked around not having those
in 5.4.

I've fixed it up and queued both of those patches.

-- 
Thanks,
Sasha