lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20210215060142.GA21977@lsv03152.swis.in-blr01.nxp.com> Date: Mon, 15 Feb 2021 11:31:42 +0530 From: Calvin Johnson <calvin.johnson@....nxp.com> To: Russell King - ARM Linux admin <linux@...linux.org.uk> Cc: Grant Likely <grant.likely@....com>, "Rafael J . Wysocki" <rafael@...nel.org>, Jeremy Linton <jeremy.linton@....com>, Andrew Lunn <andrew@...n.ch>, Andy Shevchenko <andy.shevchenko@...il.com>, Florian Fainelli <f.fainelli@...il.com>, Cristi Sovaiala <cristian.sovaiala@....com>, Florin Laurentiu Chiculita <florinlaurentiu.chiculita@....com>, Ioana Ciornei <ioana.ciornei@....com>, Madalin Bucur <madalin.bucur@....nxp.com>, Heikki Krogerus <heikki.krogerus@...ux.intel.com>, Marcin Wojtas <mw@...ihalf.com>, Pieter Jansen Van Vuuren <pieter.jansenvv@...boosystems.io>, Jon <jon@...id-run.com>, Saravana Kannan <saravanak@...gle.com>, Randy Dunlap <rdunlap@...radead.org>, Laurentiu Tudor <laurentiu.tudor@....com>, linux-kernel@...r.kernel.org, linux.cj@...il.com, Diana Madalina Craciun <diana.craciun@....com>, netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-acpi@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, Heiner Kallweit <hkallweit1@...il.com>, Jakub Kicinski <kuba@...nel.org> Subject: Re: [net-next PATCH v5 13/15] phylink: introduce phylink_fwnode_phy_connect() On Mon, Feb 08, 2021 at 03:31:11PM +0000, Russell King - ARM Linux admin wrote: > On Mon, Feb 08, 2021 at 08:42:42PM +0530, Calvin Johnson wrote: > > +int phylink_fwnode_phy_connect(struct phylink *pl, > > + struct fwnode_handle *fwnode, > > + u32 flags) > > +{ > > + struct fwnode_handle *phy_fwnode; > > + struct phy_device *phy_dev; > > + int ret; > > + > > + if (is_of_node(fwnode)) { > > + /* Fixed links and 802.3z are handled without needing a PHY */ > > + if (pl->cfg_link_an_mode == MLO_AN_FIXED || > > + (pl->cfg_link_an_mode == MLO_AN_INBAND && > > + phy_interface_mode_is_8023z(pl->link_interface))) > > + return 0; > > This difference between ACPI and DT really needs to be described in the > commit description. > > For example, why is it acceptable to have a PHY in fixed-link mode if > we're using ACPI, and not DT? > > If we look at the phylink code, accepting a PHY when in fixed-link mode > is basically not supported... so why should ACPI allow this? DT and ACPI should handle fixed-link in similar manner. I'll remove the OF check. Thanks Calvin
Powered by blists - more mailing lists