lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 15 Feb 2021 08:07:21 +0200 From: Leon Romanovsky <leon@...nel.org> To: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@...hiba.co.jp> Cc: "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Rob Herring <robh+dt@...nel.org>, Giuseppe Cavallaro <peppe.cavallaro@...com>, Alexandre Torgue <alexandre.torgue@...com>, Jose Abreu <joabreu@...opsys.com>, arnd@...nel.org, devicetree@...r.kernel.org, netdev@...r.kernel.org, punit1.agrawal@...hiba.co.jp, yuji2.ishikawa@...hiba.co.jp, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 2/4] net: stmmac: Add Toshiba Visconti SoCs glue driver On Mon, Feb 15, 2021 at 02:06:53PM +0900, Nobuhiro Iwamatsu wrote: > Add dwmac-visconti to the stmmac driver in Toshiba Visconti ARM SoCs. > This patch contains only the basic function of the device. There is no > clock control, PM, etc. yet. These will be added in the future. > > Signed-off-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@...hiba.co.jp> > --- > drivers/net/ethernet/stmicro/stmmac/Kconfig | 8 + > drivers/net/ethernet/stmicro/stmmac/Makefile | 1 + > .../ethernet/stmicro/stmmac/dwmac-visconti.c | 285 ++++++++++++++++++ > 3 files changed, 294 insertions(+) > create mode 100644 drivers/net/ethernet/stmicro/stmmac/dwmac-visconti.c > > diff --git a/drivers/net/ethernet/stmicro/stmmac/Kconfig b/drivers/net/ethernet/stmicro/stmmac/Kconfig > index 53f14c5a9e02..55ba67a550b9 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/Kconfig > +++ b/drivers/net/ethernet/stmicro/stmmac/Kconfig > @@ -219,6 +219,14 @@ config DWMAC_INTEL_PLAT > This selects the Intel platform specific glue layer support for > the stmmac device driver. This driver is used for the Intel Keem Bay > SoC. > + > +config DWMAC_VISCONTI > + bool "Toshiba Visconti DWMAC support" > + def_bool y I asked it before, but never received an answer. Why did you use "def_bool y" and not "default y"? Isn't it supposed to be "depends on STMMAC_ETH"? And probably it shouldn't be set as a default as "y". Thanks
Powered by blists - more mailing lists