linux-kernel - Re: [PATCH] drm/i915: Remove unused function pointer typedef long_pulse_detect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <YCuvRTwGxocZULT1@intel.com>
Date:   Tue, 16 Feb 2021 13:40:53 +0200
From:   Ville Syrjälä <ville.syrjala@...ux.intel.com>
To:     Chen Lin <chen45464546@....com>
Cc:     airlied@...ux.ie, daniel@...ll.ch, intel-gfx@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        Chen Lin <chen.lin5@....com.cn>, rodrigo.vivi@...el.com
Subject: Re: [PATCH] drm/i915: Remove unused function pointer typedef
 long_pulse_detect_func

On Mon, Feb 15, 2021 at 07:30:19PM +0800, Chen Lin wrote:
> From: Chen Lin <chen.lin5@....com.cn>
> 
> Remove the 'long_pulse_detect_func' typedef as it is not used.
> 
> Signed-off-by: Chen Lin <chen.lin5@....com.cn>
> ---
>  drivers/gpu/drm/i915/i915_irq.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
> index 6cdb052..c294ac6 100644
> --- a/drivers/gpu/drm/i915/i915_irq.c
> +++ b/drivers/gpu/drm/i915/i915_irq.c
> @@ -78,7 +78,6 @@ static inline void pmu_irq_stats(struct drm_i915_private *i915,
>  	WRITE_ONCE(i915->pmu.irq_count, i915->pmu.irq_count + 1);
>  }
>  
> -typedef bool (*long_pulse_detect_func)(enum hpd_pin pin, u32 val);
>  typedef u32 (*hotplug_enables_func)(struct drm_i915_private *i915,
>  				    enum hpd_pin pin);

I thought we used in when passing it as an argument to
intel_get_hpd_pins(), but looks like that's not the case.
I guess we should unify this stuff by either removing both
these typedefs and adjusting intel_hpd_hotplug_enables()
accordingly, or we should use the typedef in intel_get_hpd_pins() as
well.

-- 
Ville Syrjälä
Intel