linux-kernel - Re: [PATCH v2 2/2] exfat: add support FITRIM ioctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BYAPR04MB4965F5734BC7A2363D4C3BCD86879@BYAPR04MB4965.namprd04.prod.outlook.com>
Date:   Tue, 16 Feb 2021 23:56:44 +0000
From:   Chaitanya Kulkarni <Chaitanya.Kulkarni@....com>
To:     Hyeongseok Kim <hyeongseok@...il.com>,
        "namjae.jeon@...sung.com" <namjae.jeon@...sung.com>,
        "sj1557.seo@...sung.com" <sj1557.seo@...sung.com>
CC:     "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 2/2] exfat: add support FITRIM ioctl

On 2/16/21 14:36, Hyeongseok Kim wrote:
> +static int exfat_ioctl_fitrim(struct inode *inode, unsigned long arg)
> +{
> +	struct super_block *sb = inode->i_sb;
Do you really need sb variable ? it is only used once if I'm not wrong.
> +	struct request_queue *q = bdev_get_queue(sb->s_bdev);
> +	struct fstrim_range range;
> +	int ret = 0;