linux-kernel - Re: [PATCH v2] i2c: exynos5: Preserve high speed master code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210217083515.n5mgzgsddsks4aaw@kozik-lap>
Date:   Wed, 17 Feb 2021 09:35:15 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Mårten Lindahl <marten.lindahl@...s.com>
Cc:     kernel@...s.com,
        Mårten Lindahl <martenli@...s.com>,
        linux-i2c@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] i2c: exynos5: Preserve high speed master code

On Tue, Feb 16, 2021 at 11:25:38PM +0100, Mårten Lindahl wrote:
> From: Mårten Lindahl <martenli@...s.com>
> 
> When the driver starts to send a message with the MASTER_ID field
> set (high speed), the whole I2C_ADDR register is overwritten including
> MASTER_ID as the SLV_ADDR_MAS field is set.
> 
> This patch preserves already written fields in I2C_ADDR when writing
> SLV_ADDR_MAS.
> 
> Signed-off-by: Mårten Lindahl <martenli@...s.com>
> ---
> v2:
> - Change commit message as the problem is not in the controller but in
>   the driver.
> - Use MASTER_ID macro instead of reading back register contents.
> 
>  drivers/i2c/busses/i2c-exynos5.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 

Reviewed-by: Krzysztof Kozlowski <krzk@...nel.org>
Tested-by: Krzysztof Kozlowski <krzk@...nel.org>

Best regards,
Krzysztof