linux-kernel - Re: [PATCH v1 00/18] Add HANTRO G2/HEVC decoder support for IMX8MQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YCzVmRVL79KMkxXQ@kroah.com>
Date:   Wed, 17 Feb 2021 09:36:41 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Benjamin Gaignard <benjamin.gaignard@...labora.com>
Cc:     peng.fan@....com, kernel@...labora.com, devel@...verdev.osuosl.org,
        Anson.Huang@....com, krzk@...nel.org,
        linux-rockchip@...ts.infradead.org, wens@...e.org,
        linux-imx@....com, linux-media@...r.kernel.org,
        devicetree@...r.kernel.org, p.zabel@...gutronix.de,
        s.hauer@...gutronix.de, mripard@...nel.org, robh+dt@...nel.org,
        mchehab@...nel.org, ezequiel@...labora.com,
        linux-arm-kernel@...ts.infradead.org, aisheng.dong@....com,
        jernej.skrabec@...l.net, adrian.ratiu@...labora.com,
        linux-kernel@...r.kernel.org, paul.kocialkowski@...tlin.com,
        kernel@...gutronix.de, hverkuil-cisco@...all.nl,
        shawnguo@...nel.org, shengjiu.wang@....com
Subject: Re: [PATCH v1 00/18] Add HANTRO G2/HEVC decoder support for IMX8MQ

On Wed, Feb 17, 2021 at 09:28:09AM +0100, Benjamin Gaignard wrote:
> 
> Le 17/02/2021 à 09:08, Greg KH a écrit :
> > On Wed, Feb 17, 2021 at 09:02:48AM +0100, Benjamin Gaignard wrote:
> > > The IMX8MQ got two VPUs but until now only G1 has been enabled.
> > > This series aim to add the second VPU (aka G2) and provide basic
> > > HEVC decoding support.
> > Why are you adding this directly to drivers/staging/media/ and not
> > drivers/media/?  Why can't this just go to the main location and not
> > live in staging?
> 
> G2/HEVC is added inside the already exiting Hantro driver, it is "just"
> an other codec from Hantro driver point of view.
> In addition of that v4l2-hevc uAPI is still unstable.
> One goal of this series is to have one more consumer of this v4l2-hevc
> uAPI so maybe we can claim it to be stable enough to move away from staging
> and then do the same for Hantro driver. That would be a great achievement !

I know I do not like seeing new additions/features/whatever being added
to staging drivers as that encourages people to do new stuff on them
without doing the real work needed to get them out of staging.

So what is preventing the existing driver from getting out of staging
now?

And how are you all creating new userspace apis for staging drivers to
the v4l layer?  What happens when you export something new and then
userspace starts to rely on it and then you change it?

Anyway, the media staging drivers are on their own, I don't touch them,
it just feels odd to me...

thanks,

greg k-h