linux-kernel - 回复: [PATCH] workqueue: Move the position of debug_work_activate() in __queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BYAPR11MB2632DACFF2D6722222A3818FFF869@BYAPR11MB2632.namprd11.prod.outlook.com>
Date:   Wed, 17 Feb 2021 09:10:46 +0000
From:   "Zhang, Qiang" <Qiang.Zhang@...driver.com>
To:     "tj@...nel.org" <tj@...nel.org>,
        "jiangshanlai@...il.com" <jiangshanlai@...il.com>,
        "htejun@...il.com" <htejun@...il.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: 回复: [PATCH] workqueue: Move the position of debug_work_activate() in __queue_work()

Hello Tejun Heo

Excuse me, do you have time to make some suggestions for this modification?

Thanks
Qiang

________________________________________
发件人: Zhang, Qiang <qiang.zhang@...driver.com>
发送时间: 2021年2月11日 16:24
收件人: tj@...nel.org; jiangshanlai@...il.com
抄送: linux-kernel@...r.kernel.org
主题: [PATCH] workqueue: Move the position of debug_work_activate() in __queue_work()

From: Zqiang <qiang.zhang@...driver.com>

The debug_work_activate() is called on the premise that
the work can be inserted, because if wq be in WQ_DRAINING
status, insert work may be failed.

Signed-off-by: Zqiang <qiang.zhang@...driver.com>
---
 kernel/workqueue.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index 0d150da252e8..21fb00b52def 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -1412,7 +1412,6 @@ static void __queue_work(int cpu, struct workqueue_struct *wq,
         */
        lockdep_assert_irqs_disabled();

-       debug_work_activate(work);

        /* if draining, only works from the same workqueue are allowed */
        if (unlikely(wq->flags & __WQ_DRAINING) &&
@@ -1494,6 +1493,7 @@ static void __queue_work(int cpu, struct workqueue_struct *wq,
                worklist = &pwq->delayed_works;
        }

+       debug_work_activate(work);
        insert_work(pwq, work, worklist, work_flags);

 out:
--
2.25.1