linux-kernel - Re: [PATCH] mhi_bus: core: Return EBUSY if MHI ring is full

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eb873085-4120-7ec4-1f18-1c768ed741bd@codeaurora.org>
Date:   Wed, 17 Feb 2021 08:06:48 -0700
From:   Jeffrey Hugo <jhugo@...eaurora.org>
To:     Loic Poulain <loic.poulain@...aro.org>
Cc:     Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
        Hemant Kumar <hemantk@...eaurora.org>,
        Bhaumik Bhatt <bbhatt@...eaurora.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        Fan Wu <wufan@...eaurora.org>
Subject: Re: [PATCH] mhi_bus: core: Return EBUSY if MHI ring is full

On 2/17/2021 8:02 AM, Loic Poulain wrote:
> On Tue, 16 Feb 2021 at 19:50, Jeffrey Hugo <jhugo@...eaurora.org> wrote:
>>
>> From: Fan Wu <wufan@...eaurora.org>
>>
>> Currently ENOMEM is returned when MHI ring is full. This error code is
>> very misleading. Change to EBUSY instead.
> 
> Well, there is no space left in the ring, so it's no so misleading.

ENOMEM is typically a memory allocation failure which is not what a 
client is going to think of regarding the ring, and it's not a unique 
failure code in this case.  gen_tre can also return ENOMEM, which makes 
it difficult for the client to know if there is some significant 
failure, or they might just need to wait (assuming that is something the 
client can do).

-- 
Jeffrey Hugo
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.