linux-kernel - Re: [PATCH] mhi_bus: core: Return EBUSY if MHI ring is full

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 17 Feb 2021 17:14:34 +0100
From:   Loic Poulain <loic.poulain@...aro.org>
To:     Jeffrey Hugo <jhugo@...eaurora.org>
Cc:     Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
        Hemant Kumar <hemantk@...eaurora.org>,
        Bhaumik Bhatt <bbhatt@...eaurora.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        Fan Wu <wufan@...eaurora.org>
Subject: Re: [PATCH] mhi_bus: core: Return EBUSY if MHI ring is full

On Wed, 17 Feb 2021 at 16:06, Jeffrey Hugo <jhugo@...eaurora.org> wrote:
>
> On 2/17/2021 8:02 AM, Loic Poulain wrote:
> > On Tue, 16 Feb 2021 at 19:50, Jeffrey Hugo <jhugo@...eaurora.org> wrote:
> >>
> >> From: Fan Wu <wufan@...eaurora.org>
> >>
> >> Currently ENOMEM is returned when MHI ring is full. This error code is
> >> very misleading. Change to EBUSY instead.
> >
> > Well, there is no space left in the ring, so it's no so misleading.
>
> ENOMEM is typically a memory allocation failure which is not what a
> client is going to think of regarding the ring, and it's not a unique
> failure code in this case.  gen_tre can also return ENOMEM, which makes
> it difficult for the client to know if there is some significant
> failure, or they might just need to wait (assuming that is something the
> client can do).

Yes, fair enough, I overlooked the other thread, -EAGAIN would indeed
make sense.

Regards,
Loic