linux-kernel - Re: [PATCH] irqdomain: remove debugfs_file from struct irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4e4d0479b935e60a53f75ef534086476@kernel.org>
Date:   Wed, 17 Feb 2021 20:02:24 +0000
From:   Marc Zyngier <maz@...nel.org>
To:     Michael Walle <michael@...le.cc>
Cc:     gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
        tglx@...utronix.de
Subject: Re: [PATCH] irqdomain: remove debugfs_file from struct irq_domain

On 2021-02-17 19:57, Michael Walle wrote:
> Hi Greg,
> 
>> There's no need to keep around a dentry pointer to a simple file that
>> debugfs itself can look up when we need to remove it from the system.
>> So simplify the code by deleting the variable and cleaning up the 
>> logic
>> around the debugfs file.
> 
> This will generate the following oops on my board (arm64,
> freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dts). In debugfs_lookup()
> debugfs_mount is NULL.

That's odd. I gave it a go yesterday, and nothing blew up.
Which makes me wonder whether I had the debug stuff enabled
the first place...

I've dropped the patch from -next for now until I figure it out
(probably tomorrow).

Thanks,

         M.
-- 
Jazz is not dead. It just smells funny...