linux-kernel - Re: [PATCH] irqdomain: remove debugfs_file from struct irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5c527bfb6f3dfe31b5c25f29418306c6@walle.cc>
Date:   Wed, 17 Feb 2021 21:10:50 +0100
From:   Michael Walle <michael@...le.cc>
To:     Marc Zyngier <maz@...nel.org>
Cc:     gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
        tglx@...utronix.de
Subject: Re: [PATCH] irqdomain: remove debugfs_file from struct irq_domain

Am 2021-02-17 21:02, schrieb Marc Zyngier:
> On 2021-02-17 19:57, Michael Walle wrote:
>> Hi Greg,
>> 
>>> There's no need to keep around a dentry pointer to a simple file that
>>> debugfs itself can look up when we need to remove it from the system.
>>> So simplify the code by deleting the variable and cleaning up the 
>>> logic
>>> around the debugfs file.
>> 
>> This will generate the following oops on my board (arm64,
>> freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dts). In debugfs_lookup()
>> debugfs_mount is NULL.
> 
> That's odd. I gave it a go yesterday, and nothing blew up.
> Which makes me wonder whether I had the debug stuff enabled
> the first place...
> 
> I've dropped the patch from -next for now until I figure it out
> (probably tomorrow).

Mh, maybe its my .config, I've attached it. I also noticed that
the board boots just fine in our kernel-ci [1].

[1] https://lavalab.kontron.com/scheduler/job/8633

-michael
View attachment ".config" of type "text/plain" (174629 bytes)