linux-kernel - Re: [PATCH] percpu_counter: increase batch count

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20210218151644.df430e4f77f763b7db2a004f@linux-foundation.org>
Date:   Thu, 18 Feb 2021 15:16:44 -0800
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Jens Axboe <axboe@...nel.dk>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] percpu_counter: increase batch count

On Thu, 18 Feb 2021 14:36:31 -0700 Jens Axboe <axboe@...nel.dk> wrote:

> Currently we cap the batch count at max(32, 2*nr_online_cpus), which these
> days is kind of silly as systems have gotten much bigger than in 2009 when
> this heuristic was introduced.
> 
> Bump it to capping it at 256 instead. This has a noticeable improvement
> for certain io_uring workloads, as io_uring tracks per-task inflight count
> using percpu counters.
> 

It will also make percpu_counter_read() and
percpu_counter_read_positive() more inaccurate than at present.  Any
effects from this will take a while to discover.

But yes, worth trying - I'll add it to the post-rc1 pile.