linux-kernel - [PATCH] percpu_counter: increase batch count

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <0bf90e07-8758-b238-b3f3-a330725a1134@kernel.dk>
Date:   Thu, 18 Feb 2021 14:36:31 -0700
From:   Jens Axboe <axboe@...nel.dk>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: [PATCH] percpu_counter: increase batch count

Currently we cap the batch count at max(32, 2*nr_online_cpus), which these
days is kind of silly as systems have gotten much bigger than in 2009 when
this heuristic was introduced.

Bump it to capping it at 256 instead. This has a noticeable improvement
for certain io_uring workloads, as io_uring tracks per-task inflight count
using percpu counters.

Signed-off-by: Jens Axboe <axboe@...nel.dk>

---

diff --git a/lib/percpu_counter.c b/lib/percpu_counter.c
index 00f666d94486..c3a9af5462ba 100644
--- a/lib/percpu_counter.c
+++ b/lib/percpu_counter.c
@@ -188,7 +188,7 @@ static int compute_batch_value(unsigned int cpu)
 {
 	int nr = num_online_cpus();

-	percpu_counter_batch = max(32, nr*2);
+	percpu_counter_batch = max(256, nr*2);
 	return 0;
 }

-- 
Jens Axboe