linux-kernel - Re: [PATCH] i2c: thunderx: Fix an issue about missing call to 'pci_free_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YC43IXSzFVD8GOrJ@rric.localdomain>
Date:   Thu, 18 Feb 2021 10:45:05 +0100
From:   Robert Richter <rric@...nel.org>
To:     Dejin Zheng <zhengdejin5@...il.com>
Cc:     wsa+renesas@...g-engineering.com, jan.glauber@...il.com,
        linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c: thunderx: Fix an issue about missing call to
 'pci_free_irq_vectors()'

On 14.02.21 22:37:34, Dejin Zheng wrote:
> Call to 'pci_free_irq_vectors()' are missing both in the error handling
> path of the probe function, and in the remove function. So add them.
> 
> Fixes: 4c21541d8da17fb ("i2c: thunderx: Replace pci_enable_msix()")
> Signed-off-by: Dejin Zheng <zhengdejin5@...il.com>
> ---
>  drivers/i2c/busses/i2c-thunderx-pcidrv.c | 9 ++++++---

FTR, I reviewed the error paths of thunder_i2c_probe_pci() (v5.11-rc1)
and all look sane to me.

-Robert