linux-kernel - Re: [PATCH 2/2] arm64: dts: fsl: add support for Kontron pitx-imx8m board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJKOXPdhbwpEHA+h3706NXf0uRhyu8VVC++K8WpzA6h2=8PK8Q@mail.gmail.com>
Date:   Mon, 22 Feb 2021 19:38:47 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Heiko Thiery <heiko.thiery@...il.com>
Cc:     linux-arm-kernel@...ts.infradead.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        devicetree@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        Li Yang <leoyang.li@....com>, Michael Walle <michael@...le.cc>
Subject: Re: [PATCH 2/2] arm64: dts: fsl: add support for Kontron pitx-imx8m board

On Mon, 22 Feb 2021 at 10:09, Heiko Thiery <heiko.thiery@...il.com> wrote:
> > > > > +
> > > > > +     pcie0_refclk: pcie0-refclk {
> > > >
> > > > Generic node names (from the dt spec candidate is "clock").
> > >
> > > Should I simply set the node name to pcie0-clock? And pcie1-clock for
> > > the next one?
> >
> > I am fine with "pcie0-clock" or just "clock-0".
>
> I saw now that in "imx8mq-zii-ultra.dtsi" the name
> "clock-pcie0-refclk" is used. Can I use the same?

It's not that generic anymore - but specific, but it's also not that
important, so go ahead.

> > >
> > > When I run "make dtbs_check" it runs quite a long time and stops with
> > > an error. But as far as I can say there is an error coming from the
> > > included "imx8mq.dtsi".
> > >
> > > You can see the output here: https://pastebin.com/raw/iU2geBDh
> >
> > Looks fine (except the error tool :) ).
>
> What do you mean with error tool?

I lost some words on the wire - I meant: "except the error from the
tool itself".

Best regards,
Krzysztof