Date:   Mon, 22 Feb 2021 11:23:45 -0800
From:   Tim Chen <tim.c.chen@...ux.intel.com>
To:     Michal Hocko <mhocko@...e.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Johannes Weiner <hannes@...xchg.org>,
        Vladimir Davydov <vdavydov.dev@...il.com>,
        Dave Hansen <dave.hansen@...el.com>,
        Ying Huang <ying.huang@...el.com>, linux-mm@...ck.org,
        cgroups@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/3] mm: Force update of mem cgroup soft limit tree on
 usage excess



On 2/22/21 11:09 AM, Michal Hocko wrote:
> On Mon 22-02-21 09:41:00, Tim Chen wrote:
>>
>>
>> On 2/22/21 12:40 AM, Michal Hocko wrote:
>>> On Fri 19-02-21 10:59:05, Tim Chen wrote:
>>  occurrence.
>>>>>
>>>>> Soft limit is evaluated every THRESHOLDS_EVENTS_TARGET * SOFTLIMIT_EVENTS_TARGET.
>>>>> If all events correspond with a newly charged memory and the last event
>>>>> was just about the soft limit boundary then we should be bound by 128k
>>>>> pages (512M and much more if this were huge pages) which is a lot!
>>>>> I haven't realized this was that much. Now I see the problem. This would
>>>>> be a useful information for the changelog.
>>>>>
>>>>> Your fix is focusing on the over-the-limit boundary which will solve the
>>>>> problem but wouldn't that lead to to updates happening too often in
>>>>> pathological situation when a memcg would get reclaimed immediatelly?
>>>>
>>>> Not really immediately.  The memcg that has the most soft limit excess will
>>>> be chosen for page reclaim, which is the way it should be.  
>>>> It is less likely that a memcg that just exceeded
>>>> the soft limit becomes the worst offender immediately. 
>>>
>>> Well this all depends on when the the soft limit reclaim triggeres. In
>>> other words how often you see the global memory reclaim. If we have a
>>> memcg with a sufficient excess then this will work mostly fine. I was more
>>> worried about a case when you have memcgs just slightly over the limit
>>> and the global memory pressure is a regular event. You can easily end up
>>> bouncing memcgs off and on the tree in a rapid fashion. 
>>>
>>
>> If you are concerned about such a case, we can add an excess threshold,
>> say 4 MB (or 1024 4K pages), before we trigger a forced update. You think
>> that will cover this concern?
> 
> Yes some sort of rate limiting should help. My understanding has been
> that this is the main purpose of the even counting threshold. The code
> as we have doesn't seem to work properly so there are two ways, either
> tune the existing threshold or replace it by something else. Having both
> a force update and non-functional threshold is not a great outcome.
> 

The event counting threshold's purpose is to limit the *rate*  of event update.  The
side effect is we will miss some update by the sampling nature.  However, we can't
afford to let the sampling go to frequent or the overhead will be too much.

The forced update makes sure that a needed update happens 
to put the memcg on the tree happens and we don't allow the
memcg to escape page reclaim even if the update happens relatively rarely.  Lowering
the threshold does not guarantee that the update happens, resulting in a runaway
memcg.  The forced update and threshold serves different purpose. In my opinion
the forced update is necessary.  We can keep the update overhead low with
low update rate, and yet make sure that a needed update happens.  I think both
are necessary for proper function.  The overhead from the forced update
is negligible and I don't a downside adding it. 

Tim

Powered by blists - more mailing lists