linux-kernel - Re: [PATCH] drm/amdgpu: stream's id should reduced after stream destruct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <cc528ba3-490d-dc19-16d4-43c27a6af203@amd.com>
Date:   Mon, 22 Feb 2021 14:24:59 -0500
From:   "Kazlauskas, Nicholas" <nicholas.kazlauskas@....com>
To:     "ZhiJie.Zhang" <zhangzhijie@...ngson.cn>,
        alexander.deucher@....com, airlied@...ux.ie, daniel@...ll.ch,
        christian.koenig@....com
Cc:     mchehab+huawei@...nel.org, amd-gfx@...ts.freedesktop.org,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/amdgpu: stream's id should reduced after stream
 destruct

On 2021-02-20 1:30 a.m., ZhiJie.Zhang wrote:
> Signed-off-by: ZhiJie.Zhang <zhangzhijie@...ngson.cn>
> ---
>   drivers/gpu/drm/amd/display/dc/core/dc_stream.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_stream.c b/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
> index c103f858375d..dc7b7e57a86c 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
> @@ -137,6 +137,8 @@ static void dc_stream_destruct(struct dc_stream_state *stream)
>   		dc_transfer_func_release(stream->out_transfer_func);
>   		stream->out_transfer_func = NULL;
>   	}
> +
> +	stream->ctx->dc_stream_id_count--;

This is supposed to be a unique identifier so we shouldn't be reusing 
any old ID when creating a new stream.

Regards,
Nicholas Kazlauskas

>   }
>   
>   void dc_stream_retain(struct dc_stream_state *stream)
>