linux-kernel - Re: [PATCH v2 1/3] add params and ids to support nist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2e829730-bb0c-47eb-70f2-731c184eba33@linux.ibm.com>
Date:   Mon, 22 Feb 2021 13:37:41 -0500
From:   Stefan Berger <stefanb@...ux.ibm.com>
To:     Saulo Alessandre <saulo.alessandre@...il.com>
Cc:     davem@...emloft.net, dhowells@...hat.com,
        herbert@...dor.apana.org.au, keyrings@...r.kernel.org,
        linux-crypto@...r.kernel.org, linux-integrity@...r.kernel.org,
        linux-kernel@...r.kernel.org, patrick@...terwijk.org,
        zohar@...ux.ibm.com, Saulo Alessandre <saulo.alessandre@....jus.br>
Subject: Re: [PATCH v2 1/3] add params and ids to support nist_p384

On 2/22/21 12:58 PM, Saulo Alessandre wrote:
> From: Saulo Alessandre <saulo.alessandre@....jus.br>
>
> * crypto/asymmetric_keys/x509_cert_parser.c
>    - prepare x509 parser to load nist_secp384r1
>
> * crypto/ecc_curve_defs.h
>    - add nist_p384 params
>
> * include/crypto/ecdh.h
>    - add ECC_CURVE_NIST_P384
>
> * include/linux/oid_registry.h
>    - reorder OID_id_ecdsa_with_sha1
>    - add OID_id_secp384r1
>
> Signed-off-by: Saulo Alessandre <saulo.alessandre@....jus.br>

I would separate this patch into an x509: and certs: part since it 
touches two subsystems.

I can take this series of patches and post my v9 including them at the 
end. This would make it easier for others to test. I would massage them 
a bit, including the separation of the 1st patch into 2 patches, if you 
don't mind, preserving your Signed-off-by. I need to fix something in my 
v8 regarding registration failure handling. Let me know whether this is 
fine with you.

I had tested your patches over the weekend with my endless test tool 
creating keys in user space and loading them into the kernel. It worked 
fine for NIST p256 & p384. Also signing kernel modules with NIST p384 is 
working fine.

So, for the series:

Tested-by: Stefan Berger <stefanb@...ux.ibm.com>

Regards,

     Stefan