linux-kernel - Re: [PATCH v2 1/3] add params and ids to support nist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 24 Feb 2021 10:35:30 -0300
From:   Saulo Alessandre de Lima <saulo.alessandre@...il.com>
To:     linux-crypto@...r.kernel.org
Cc:     linux-integrity@...r.kernel.org, linux-kernel@...r.kernel.org,
        keyrings@...r.kernel.org
Subject: Re: [PATCH v2 1/3] add params and ids to support nist_p384

Em seg., 22 de fev. de 2021 às 17:26, Stefan Berger
<stefanb@...ux.ibm.com> escreveu:
>
> On 2/22/21 12:58 PM, Saulo Alessandre wrote:
> > From: Saulo Alessandre <saulo.alessandre@....jus.br>
> >
> > * crypto/asymmetric_keys/x509_cert_parser.c
> >    - prepare x509 parser to load nist_secp384r1
> >
> > * crypto/ecc_curve_defs.h
> >    - add nist_p384 params
> >
> > * include/crypto/ecdh.h
> >    - add ECC_CURVE_NIST_P384
> >
> > * include/linux/oid_registry.h
> >    - reorder OID_id_ecdsa_with_sha1
> >    - add OID_id_secp384r1
> >
> > Signed-off-by: Saulo Alessandre <saulo.alessandre@....jus.br>
>
> I would separate this patch into an x509: and certs: part since it
> touches two subsystems.
>
> I can take this series of patches and post my v9 including them at the
> end. This would make it easier for others to test. I would massage them
> a bit, including the separation of the 1st patch into 2 patches, if you
> don't mind, preserving your Signed-off-by. I need to fix something in my
> v8 regarding registration failure handling. Let me know whether this is
> fine with you.

For me it's ok.

>
> I had tested your patches over the weekend with my endless test tool
> creating keys in user space and loading them into the kernel. It worked
> fine for NIST p256 & p384. Also signing kernel modules with NIST p384 is
> working fine.
>
> So, for the series:
>
> Tested-by: Stefan Berger <stefanb@...ux.ibm.com>
>
> Regards,
>
>      Stefan
>
>

Regards
-- 
[]'s
-----
Saulo Alessandre <saulo.alessandre@...il.com>