linux-kernel - [PATCH] regulator: pca9450: Fix return value when failing to get sd-vsel GPIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20210222150809.208942-1-frieder.schrempf@kontron.de>
Date:   Mon, 22 Feb 2021 16:08:04 +0100
From:   Schrempf Frieder <frieder.schrempf@...tron.de>
To:     Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>
Cc:     Frieder Schrempf <frieder.schrempf@...tron.de>,
        Rikard Falkeborn <rikard.falkeborn@...il.com>,
        Robin Gong <yibin.gong@....com>,
        Axel Lin <axel.lin@...ics.com>, linux-kernel@...r.kernel.org
Subject: [PATCH] regulator: pca9450: Fix return value when failing to get sd-vsel GPIO

From: Frieder Schrempf <frieder.schrempf@...tron.de>

This fixes the return value of pca9450_i2c_probe() to use the correct
error code when getting the sd-vsel GPIO fails.

Signed-off-by: Frieder Schrempf <frieder.schrempf@...tron.de>
---
 drivers/regulator/pca9450-regulator.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/pca9450-regulator.c b/drivers/regulator/pca9450-regulator.c
index d38109cc3a01..2f7ee212cb8c 100644
--- a/drivers/regulator/pca9450-regulator.c
+++ b/drivers/regulator/pca9450-regulator.c
@@ -822,7 +822,7 @@ static int pca9450_i2c_probe(struct i2c_client *i2c,
 
 	if (IS_ERR(pca9450->sd_vsel_gpio)) {
 		dev_err(&i2c->dev, "Failed to get SD_VSEL GPIO\n");
-		return ret;
+		return PTR_ERR(pca9450->sd_vsel_gpio);
 	}
 
 	dev_info(&i2c->dev, "%s probed.\n",
-- 
2.25.1