linux-kernel - Re: [PATCH] regulator: pca9450: Fix return value when failing to get sd-vsel GPIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e0c35d5c-1deb-e5db-df85-c508c6b2f228@kontron.de>
Date:   Mon, 22 Feb 2021 16:16:06 +0100
From:   Frieder Schrempf <frieder.schrempf@...tron.de>
To:     Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>
Cc:     Rikard Falkeborn <rikard.falkeborn@...il.com>,
        Robin Gong <yibin.gong@....com>,
        Axel Lin <axel.lin@...ics.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regulator: pca9450: Fix return value when failing to get
 sd-vsel GPIO

On 22.02.21 16:08, Schrempf Frieder wrote:
> From: Frieder Schrempf <frieder.schrempf@...tron.de>
> 
> This fixes the return value of pca9450_i2c_probe() to use the correct
> error code when getting the sd-vsel GPIO fails.
> 
> Signed-off-by: Frieder Schrempf <frieder.schrempf@...tron.de>

Sorry, I just noticed, that the PR for v5.12 was already sent, but I 
think not yet pulled by Linus. So I probably should have waited for this 
to happen and added a proper Fixes tag. I guess I will just resend after 
the faulty patch found its way into Linus' tree.

> ---
>   drivers/regulator/pca9450-regulator.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/regulator/pca9450-regulator.c b/drivers/regulator/pca9450-regulator.c
> index d38109cc3a01..2f7ee212cb8c 100644
> --- a/drivers/regulator/pca9450-regulator.c
> +++ b/drivers/regulator/pca9450-regulator.c
> @@ -822,7 +822,7 @@ static int pca9450_i2c_probe(struct i2c_client *i2c,
>   
>   	if (IS_ERR(pca9450->sd_vsel_gpio)) {
>   		dev_err(&i2c->dev, "Failed to get SD_VSEL GPIO\n");
> -		return ret;
> +		return PTR_ERR(pca9450->sd_vsel_gpio);
>   	}
>   
>   	dev_info(&i2c->dev, "%s probed.\n",
>