[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <874ki3i13w.fsf@codeaurora.org>
Date: Tue, 23 Feb 2021 11:29:07 +0200
From: Kalle Valo <kvalo@...eaurora.org>
To: Pkshih <pkshih@...ltek.com>
Cc: "linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>,
"tony0620emma\@gmail.com" <tony0620emma@...il.com>,
Timlee <timlee@...ltek.com>,
"zhanjun\@uniontech.com" <zhanjun@...ontech.com>,
"kuba\@kernel.org" <kuba@...nel.org>,
"netdev\@vger.kernel.org" <netdev@...r.kernel.org>,
"davem\@davemloft.net" <davem@...emloft.net>,
"arnd\@arndb.de" <arnd@...db.de>,
"chenhaoa\@uniontech.com" <chenhaoa@...ontech.com>,
"linux-wireless\@vger.kernel.org" <linux-wireless@...r.kernel.org>
Subject: Re: [PATCH v2] rtw88: 8822ce: fix wifi disconnect after S3/S4 on HONOR laptop
Pkshih <pkshih@...ltek.com> writes:
> On Tue, 2021-02-23 at 09:08 +0200, Kalle Valo wrote:
>> Pkshih <pkshih@...ltek.com> writes:
>>
>> >> > --- a/drivers/net/wireless/realtek/rtw88/rtw8822ce.c
>> >> > +++ b/drivers/net/wireless/realtek/rtw88/rtw8822ce.c
>> >> > @@ -25,7 +25,6 @@ static struct pci_driver rtw_8822ce_driver = {
>> >> > .id_table = rtw_8822ce_id_table,
>> >> > .probe = rtw_pci_probe,
>> >> > .remove = rtw_pci_remove,
>> >> > - .driver.pm = &rtw_pm_ops,
>> >>
>> >> Why just 8822ce? Why not remove rtw_pm_ops entirely if it just creates
>> >> problems?
>> >
>> > I think we can't remove rtw_pm_ops, because wowlan will not work.
>>
>> Ah. A comment code in the code stating that would be nice.
>>
>
> I'll do it.
Thank you.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Powered by blists - more mailing lists