linux-kernel - Re: [PATCH 1/2] dt-bindings: usb: generic-ehci: document ignore-oc flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <54E1894F-C8D8-4E2F-92DF-DC891153BAAB@gmail.com>
Date:   Tue, 23 Feb 2021 17:04:57 +0100
From:   Álvaro Fernández Rojas <noltari@...il.com>
To:     Alan Stern <stern@...land.harvard.edu>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        Jonas Gorski <jonas.gorski@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Rob Herring <robh+dt@...nel.org>,
        Tony Prisk <linux@...sktech.co.nz>, linux-usb@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/2] dt-bindings: usb: generic-ehci: document ignore-oc
 flag

Hi Alan,

> El 23 feb 2021, a las 16:54, Alan Stern <stern@...land.harvard.edu> escribió:
> 
> On Tue, Feb 23, 2021 at 04:50:04PM +0100, Álvaro Fernández Rojas wrote:
>> Over-current reporting isn't supported on some platforms such as bcm63xx.
>> These devices will incorrectly report over-current if this flag isn't properly
>> activated.
>> 
>> Signed-off-by: Álvaro Fernández Rojas <noltari@...il.com>
>> ---
>> Documentation/devicetree/bindings/usb/generic-ehci.yaml | 5 +++++
>> 1 file changed, 5 insertions(+)
>> 
>> diff --git a/Documentation/devicetree/bindings/usb/generic-ehci.yaml b/Documentation/devicetree/bindings/usb/generic-ehci.yaml
>> index cf83f2d9afac..294bbf02399e 100644
>> --- a/Documentation/devicetree/bindings/usb/generic-ehci.yaml
>> +++ b/Documentation/devicetree/bindings/usb/generic-ehci.yaml
>> @@ -117,6 +117,11 @@ properties:
>>       Set this flag if EHCI has a Transaction Translator built into
>>       the root hub.
>> 
>> +  ignore-oc:
>> +    $ref: /schemas/types.yaml#/definitions/flag
>> +    description:
>> +      Set this flag for HCDs without over-current reporting support.
> 
> This is not a good description of a device property.  DT entries are 
> supposed to described the hardware, not talk about how to use it.

Any suggestions on a proper description?

> 
> When you say that the bcm63xx doesn't support over-current reporting, 
> what exactly do you mean?  Do you mean that sometimes the hardware turns 
> on the over-current bit when an over-current isn't actually present?  Or 
> do you mean something else?

Yes, the hardware turns on the over-current bit with no over-current present.

> 
> Alan Stern
> 
>> +
>>   needs-reset-on-resume:
>>     $ref: /schemas/types.yaml#/definitions/flag
>>     description:
>> -- 
>> 2.20.1

Best regards,
Álvaro.