linux-kernel - Re: [PATCH] usb: dwc3: qcom: Honor wakeup enabled/disabled state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YDU5ujJy5xiDXAJ3@google.com>
Date:   Tue, 23 Feb 2021 09:22:02 -0800
From:   Matthias Kaehlcke <mka@...omium.org>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:     Andy Gross <agross@...nel.org>, Felipe Balbi <balbi@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Douglas Anderson <dianders@...omium.org>,
        Manu Gautam <mgautam@...eaurora.org>,
        linux-usb@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        Lee Jones <lee.jones@...aro.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: dwc3: qcom: Honor wakeup enabled/disabled state

ping

I noticed this was never picked up, can it be landed or are there any
concerns with this patch?

On Tue, Sep 15, 2020 at 06:50:32PM -0500, Bjorn Andersson wrote:
> On Tue 15 Sep 14:31 CDT 2020, Matthias Kaehlcke wrote:
> 
> > The dwc3-qcom currently enables wakeup interrupts unconditionally
> > when suspending, however this should not be done when wakeup is
> > disabled (e.g. through the sysfs attribute power/wakeup). Only
> > enable wakeup interrupts when device_may_wakeup() returns true.
> > 
> > Fixes: a4333c3a6ba9 ("usb: dwc3: Add Qualcomm DWC3 glue driver")
> > Signed-off-by: Matthias Kaehlcke <mka@...omium.org>
> 
> Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org>
> 
> Regards,
> Bjorn
> 
> > ---
> > 
> >  drivers/usb/dwc3/dwc3-qcom.c | 7 +++++--
> >  1 file changed, 5 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c
> > index e1e78e9824b1..56d14c09506d 100644
> > --- a/drivers/usb/dwc3/dwc3-qcom.c
> > +++ b/drivers/usb/dwc3/dwc3-qcom.c
> > @@ -251,8 +251,10 @@ static int dwc3_qcom_suspend(struct dwc3_qcom *qcom)
> >  	for (i = qcom->num_clocks - 1; i >= 0; i--)
> >  		clk_disable_unprepare(qcom->clks[i]);
> >  
> > +	if (device_may_wakeup(qcom->dev))
> > +		dwc3_qcom_enable_interrupts(qcom);
> > +
> >  	qcom->is_suspended = true;
> > -	dwc3_qcom_enable_interrupts(qcom);
> >  
> >  	return 0;
> >  }
> > @@ -265,7 +267,8 @@ static int dwc3_qcom_resume(struct dwc3_qcom *qcom)
> >  	if (!qcom->is_suspended)
> >  		return 0;
> >  
> > -	dwc3_qcom_disable_interrupts(qcom);
> > +	if (device_may_wakeup(qcom->dev))
> > +		dwc3_qcom_disable_interrupts(qcom);
> >  
> >  	for (i = 0; i < qcom->num_clocks; i++) {
> >  		ret = clk_prepare_enable(qcom->clks[i]);
> > -- 
> > 2.28.0.618.gf4bc123cb7-goog
> >