linux-kernel - RE: linux-next: build warning in Linus' tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 23 Feb 2021 22:01:02 +0000
From:   "Ernst, Justin" <justin.ernst@....com>
To:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Borislav Petkov <bp@...e.de>,
        Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
CC:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "Linux Next Mailing List" <linux-next@...r.kernel.org>,
        "Anderson, Russ" <russ.anderson@....com>
Subject: RE: linux-next: build warning in Linus' tree

> Hi all,
> 
> On Thu, 18 Feb 2021 22:47:57 +0000 "Ernst, Justin" <justin.ernst@....com> wrote:
> >
> > Hi,
> > We made a special effort to squash the unexpected indentation warnings in c159376490ee
> (https://lore.kernel.org/lkml/20201130214304.369348-1-justin.ernst@hpe.com/), so I was surprised to
> see this again.
> > Commit:
> >
> > 	c9624cb7db1c ("x86/platform/uv: Update sysfs documentation")
> >
> > is the culprit here. I suspect it was written and submitted before we made the effort to fix the
> Unexpected indentation in c159376490ee, so it misplaced the first line of a codeblock, the original
> problem that was reported and fixed.
> >
> > The fix:
> >
> > diff --git a/Documentation/ABI/testing/sysfs-firmware-sgi_uv b/Documentation/ABI/testing/sysfs-
> firmware-sgi_uv
> > index 637c668cbe45..12ed843e1d3e 100644
> > --- a/Documentation/ABI/testing/sysfs-firmware-sgi_uv
> > +++ b/Documentation/ABI/testing/sysfs-firmware-sgi_uv
> > @@ -39,8 +39,8 @@ Description:
> >
> >                 The uv_type entry contains the hub revision number.
> >                 This value can be used to identify the UV system version::
> > -                       "0.*" = Hubless UV ('*' is subtype)
> >
> > +                       "0.*" = Hubless UV ('*' is subtype)
> >                         "3.0" = UV2
> >                         "5.0" = UV3
> >                         "7.0" = UV4
> >
> > Thanks,
> > Justin
> >
> > > Building Linus' tree, today's linux-next build (htmldocs) produced
> > > this warning:
> > >
> > > Documentation/ABI/testing/sysfs-firmware-sgi_uv:2: WARNING: Unexpected indentation.
> > >
> > > Introduced by commit
> > >
> > >   c159376490ee ("x86/platform/uv: Update ABI documentation of /sys/firmware/sgi_uv/")
> > >
> > > Or maybe an ealier one.
> > >
> > > This has been around for some time.
> 
> I am still seeing this warning.

I submitted a patch here: https://lore.kernel.org/lkml/20210219182852.385297-1-justin.ernst@hpe.com/

Thanks,
Justin Ernst

> 
> --
> Cheers,
> Stephen Rothwell