linux-kernel - Re: [PATCH] [RFC]ARM: ftrace: pause/unpause function graph tracer in cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210224112001.GR1463@shell.armlinux.org.uk>
Date:   Wed, 24 Feb 2021 11:20:02 +0000
From:   Russell King - ARM Linux admin <linux@...linux.org.uk>
To:     liang wang <liang26812@...il.com>
Cc:     linux-kernel@...r.kernel.org, penberg@...nel.org,
        geert@...ux-m68k.org, rppt@...nel.org, akpm@...ux-foundation.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] [RFC]ARM: ftrace: pause/unpause function graph tracer in
 cpu_suspend()

On Wed, Feb 24, 2021 at 07:14:54PM +0800, liang wang wrote:
> Hi Russell,
> 
> On Wed, 24 Feb 2021 at 18:39, Russell King - ARM Linux admin
> <linux@...linux.org.uk> wrote:
> >
> > On Wed, Feb 24, 2021 at 06:35:47PM +0800, liang wang wrote:
> > > Hi,all
> > >
> > > ftrace function_graph tracer always cause kernel panic on my ARM device with
> > > multiple CPUs, I found a solution for the problem on ARM64, refers to
> > > the patch above,
> > > I was wondering why this bugfix on ARM64 hasn't been upstreamed to ARM,
> >
> > Patches get applied to the ARM tree after they've been submitted to
> > the patch system. If they don't get submitted to the patch system,
> > then they get buried and forgotten.
> >
> > --
> > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> > FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
> 
> Thanks for replying,
> So I refers to the solution on ARM64 and sent my patch on January as below.
> 
> http://lists.infradead.org/pipermail/linux-arm-kernel/2021-January/628460.html
> 
> But I haven't got any replies on my patch. How can I get my patch reviewed
> and submitted to the patch system?

I don't use ftrace, so I'm not the right person to review it - but it
seems that lots of patches for ARM are left to me to try and review,
despite me not knowing sufficient to know whether it's correct or not.
This isn't sustainable.

> Should I resend a new patch to this maillist?

You can try but I suspect the same thing will happen. The only thing I
can think is if you put it in the patch system and I apply it, if
someone has a problem with it, they'll shout about it soon enough. Not
the best way, but I don't see much other option.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!