linux-kernel - Re: [tcp] 9d9b1ee0b2: packetdrill.packetdrill/gtests/net/tcp/user_timeout/user-timeout-probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210224141302.GA13714@xsang-OptiPlex-9020>
Date:   Wed, 24 Feb 2021 22:13:02 +0800
From:   Oliver Sang <oliver.sang@...el.com>
To:     Neal Cardwell <ncardwell@...gle.com>
Cc:     Enke Chen <enchen@...oaltonetworks.com>,
        Jakub Kicinski <kuba@...nel.org>,
        William McCall <william.mccall@...il.com>,
        Yuchung Cheng <ycheng@...gle.com>,
        Eric Dumazet <edumazet@...gle.com>,
        LKML <linux-kernel@...r.kernel.org>, lkp@...ts.01.org,
        kbuild test robot <lkp@...el.com>
Subject: Re: [tcp] 9d9b1ee0b2:
 packetdrill.packetdrill/gtests/net/tcp/user_timeout/user-timeout-probe_ipv4-mapped-v6.fail

Hi, Neal,

On Fri, Feb 19, 2021 at 09:52:04AM -0500, Neal Cardwell wrote:
> On Thu, Feb 18, 2021 at 8:33 PM kernel test robot <oliver.sang@...el.com> wrote:
> >
> >
> > Greeting,
> >
> > FYI, we noticed the following commit (built with gcc-9):
> >
> > commit: 9d9b1ee0b2d1c9e02b2338c4a4b0a062d2d3edac ("tcp: fix TCP_USER_TIMEOUT with zero window")
> > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master
> 
> I have pushed to the packetdrill repo a commit that should fix this test:
> 
> 094da3bc77e5 (HEAD, packetdrill/master) net-test: update TCP tests for
> USER_TIMEOUT ZWP fix
> https://github.com/google/packetdrill/commit/094da3bc77e518d820ebc0ef8b94a5b4cf707a39
> 
> Can someone please pull that commit into the repo used by the test
> bot, if needed? (Or does it automatically use the latest packetdrill
> master branch?)

We updated our tool to use this latest packetdrill. seems improved, but not totally fix.

before upgrading, we have:
b889c7c8c02ebb0b 9d9b1ee0b2d1c9e02b2338c4a4b
---------------- ---------------------------
       fail:runs  %reproduction    fail:runs
           |             |             |
           :6          100%           6:6     packetdrill.packetdrill/gtests/net/tcp/user_timeout/user-timeout-probe_ipv4-mapped-v6.fail
           :6          100%           6:6     packetdrill.packetdrill/gtests/net/tcp/user_timeout/user-timeout-probe_ipv4.fail

after upgrading, we have:
b889c7c8c02ebb0b 9d9b1ee0b2d1c9e02b2338c4a4b
---------------- ---------------------------
       fail:runs  %reproduction    fail:runs
           |             |             |
           :6          100%           5:6     packetdrill.packetdrill/gtests/net/tcp/user_timeout/user-timeout-probe_ipv4-mapped-v6.fail
           :6          100%           3:6     packetdrill.packetdrill/gtests/net/tcp/user_timeout/user-timeout-probe_ipv4.fail


attached kmsg.xz and packetdrill from one run where both tests failed.


> 
> thanks,
> neal

Download attachment "kmsg.xz" of type "application/x-xz" (24088 bytes)

View attachment "packetdrill" of type "text/plain" (26867 bytes)