lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20210224140347.GS1463@shell.armlinux.org.uk> Date: Wed, 24 Feb 2021 14:03:47 +0000 From: Russell King - ARM Linux admin <linux@...linux.org.uk> To: Maninder Singh <maninder1.s@...sung.com> Cc: cl@...ux.com, penberg@...nel.org, rientjes@...gle.com, iamjoonsoo.kim@....com, akpm@...ux-foundation.org, vbabka@...e.cz, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, linux-mm@...ck.org, a.sahrawat@...sung.com, Vaneet Narang <v.narang@...sung.com> Subject: Re: [PATCH 1/1] arm: print alloc free paths for address in registers On Wed, Feb 24, 2021 at 06:07:34PM +0530, Maninder Singh wrote: > +bool slab_page_object(unsigned long address, void **object, struct kmem_cache **cache) > +{ > + void *addr = (void *)address; > + struct page *page; > + > + if ((addr >= (void *)PAGE_OFFSET) && > + (addr < high_memory)) { > + page = virt_to_head_page(addr); This check is not sufficient. There can be holes in the page array. You need to use virt_addr_valid() to validate "addr". -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
Powered by blists - more mailing lists