linux-kernel - Re: [PATCH] kbuild: lto: add _mcount to list of used symbols

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202102251214.4CCD3FF13@keescook>
Date:   Thu, 25 Feb 2021 12:14:35 -0800
From:   Kees Cook <keescook@...omium.org>
To:     Arnd Bergmann <arnd@...nel.org>
Cc:     Sami Tolvanen <samitolvanen@...gle.com>,
        Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kbuild: lto: add _mcount to list of used symbols

On Thu, Feb 25, 2021 at 03:34:49PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> Some randconfig builds fail with undefined references to _mcount
> when CONFIG_TRIM_UNUSED_KSYMS is set:
> 
> ERROR: modpost: "_mcount" [drivers/tee/optee/optee.ko] undefined!
> ERROR: modpost: "_mcount" [drivers/fsi/fsi-occ.ko] undefined!
> ERROR: modpost: "_mcount" [drivers/fpga/dfl-pci.ko] undefined!
> 
> Since there is already a list of symbols that get generated at link
> time, add this one as well.
> 
> Fixes: fbe078d397b4 ("kbuild: lto: add a default list of used symbols")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Thanks!

Reviewed-by: Kees Cook <keescook@...omium.org>

-- 
Kees Cook