linux-kernel - Re: [PATCH] radeon: ERROR: space prohibited before that ','

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <170cf966-2248-605a-d640-8e574f94b419@amd.com>
Date:   Fri, 26 Feb 2021 08:48:54 +0100
From:   Christian König <christian.koenig@....com>
To:     wangjingyu <wangjingyu@...ontech.com>, airlied@...ux.ie,
        daniel@...ll.ch
Cc:     alexander.deucher@....com, amd-gfx@...ts.freedesktop.org,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] radeon: ERROR: space prohibited before that ','

Well coding style clean ups are usually welcome, but not necessarily one 
by one.

We can probably merge this if you clean up all checkpatch.pl warnings in 
the whole file.

Christian.

Am 26.02.21 um 07:05 schrieb wangjingyu:
> drm_property_create_range(rdev->ddev, 0 , "coherent", 0, 1);
>
> Signed-off-by: wangjingyu <wangjingyu@...ontech.com>
> ---
>   drivers/gpu/drm/radeon/radeon_display.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/drm/radeon/radeon_display.c
> index 3a6fedad002d..439d1b3e87d8 100644
> --- a/drivers/gpu/drm/radeon/radeon_display.c
> +++ b/drivers/gpu/drm/radeon/radeon_display.c
> @@ -1396,7 +1396,7 @@ static int radeon_modeset_create_props(struct radeon_device *rdev)
>   
>   	if (rdev->is_atom_bios) {
>   		rdev->mode_info.coherent_mode_property =
> -			drm_property_create_range(rdev->ddev, 0 , "coherent", 0, 1);
> +			drm_property_create_range(rdev->ddev, 0, "coherent", 0, 1);
>   		if (!rdev->mode_info.coherent_mode_property)
>   			return -ENOMEM;
>   	}