linux-kernel - Re: [PATCH v1 1/1] HID: i2c-hid: acpi: Drop redundant ACPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VfwaxOHA3hUDCXVSiOrNfrT4jNxd6+d6DmL+mZDyy_68w@mail.gmail.com>
Date:   Fri, 26 Feb 2021 20:45:54 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Douglas Anderson <dianders@...omium.org>,
        linux-input <linux-input@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Jiri Kosina <jikos@...nel.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>
Subject: Re: [PATCH v1 1/1] HID: i2c-hid: acpi: Drop redundant ACPI_PTR()

On Fri, Feb 26, 2021 at 8:35 PM Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:
>
> The driver depends on ACPI, ACPI_PTR() resolution is always the same.
> Otherwise a compiler may produce a warning.
>
> That said, the rule of thumb either ugly ifdeffery with ACPI_PTR or
> none should be used in a driver.

Oh, I see more improvements can be done, so, I will send this and the
rest as v2 altogether.

--
With Best Regards,
Andy Shevchenko