linux-kernel - Re: [PATCH v6 bpf-next 0/6] bpf: enable task local storage for tracing programs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAADnVQKofEPSABz-+WQ65XTcOEQPke08Nity2Mo7-bD2gopVpg@mail.gmail.com>
Date:   Fri, 26 Feb 2021 12:03:43 -0800
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Martin KaFai Lau <kafai@...com>
Cc:     Song Liu <songliubraving@...com>, bpf <bpf@...r.kernel.org>,
        Network Development <netdev@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Kernel Team <kernel-team@...com>,
        Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH v6 bpf-next 0/6] bpf: enable task local storage for
 tracing programs

On Thu, Feb 25, 2021 at 4:04 PM Martin KaFai Lau <kafai@...com> wrote:
>
> On Thu, Feb 25, 2021 at 03:43:13PM -0800, Song Liu wrote:
> > This set enables task local storage for non-BPF_LSM programs.
> >
> > It is common for tracing BPF program to access per-task data. Currently,
> > these data are stored in hash tables with pid as the key. In
> > bcc/libbpftools [1], 9 out of 23 tools use such hash tables. However,
> > hash table is not ideal for many use case. Task local storage provides
> > better usability and performance for BPF programs. Please refer to 6/6 for
> > some performance comparison of task local storage vs. hash table.
> Thanks for the patches.
>
> Acked-by: Martin KaFai Lau <kafai@...com>

Applied. Thanks.

9 out of 23 libbpf-tools will significantly reduce the tracing overhead. Hooray!