linux-kernel - Re: [PATCH] RISC-V: Make NUMA depend on SMP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 26 Feb 2021 19:07:25 -0800 (PST)
From:   Palmer Dabbelt <palmer@...belt.com>
To:     wangkefeng.wang@...wei.com
CC:     akpm@...ux-foundation.org, atishp@...shpatra.org,
        aou@...s.berkeley.edu, linux-kernel@...r.kernel.org,
        Paul Walmsley <paul.walmsley@...ive.com>,
        linux-riscv@...ts.infradead.org, kernel-team@...roid.com
Subject:     Re: [PATCH] RISC-V: Make NUMA depend on SMP

On Fri, 26 Feb 2021 17:03:53 PST (-0800), wangkefeng.wang@...wei.com wrote:
>
> On 2021/2/27 4:25, Palmer Dabbelt wrote:
>> From: Palmer Dabbelt <palmerdabbelt@...gle.com>
>>
>> In theory these are orthogonal, but in practice all NUMA systems are
>> SMP.  NUMA && !SMP doesn't build, everyone else is coupling them, and I
>> don't really see any value in supporting that configuration.
>>
>> Fixes: 4f0e8eef772e ("riscv: Add numa support for riscv64 platform")
>> Suggested-by: Andrew Morton <akpm@...ux-foundation.org>
>> Suggested-by: Atish Patra <atishp@...shpatra.org>
>> Signed-off-by: Palmer Dabbelt <palmerdabbelt@...gle.com>
>
> Reported-and-Tested-by:  Kefeng Wang <wangkefeng.wang@...wei.com>

Ah, thanks, I forged I'd said no to this earlier ;)

>
>
>> ---
>> This is on fixes.
>> ---
>>   arch/riscv/Kconfig | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
>> index a998babc1237..85d626b8ce5e 100644
>> --- a/arch/riscv/Kconfig
>> +++ b/arch/riscv/Kconfig
>> @@ -314,6 +314,7 @@ endchoice
>>   # Common NUMA Features
>>   config NUMA
>>   	bool "NUMA Memory Allocation and Scheduler Support"
>> +	depends on SMP
>>   	select GENERIC_ARCH_NUMA
>>   	select OF_NUMA
>>   	select ARCH_SUPPORTS_NUMA_BALANCING