linux-kernel - Re: [PATCH 2/2] drivers: misc: add ripple counter driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vdrsr8zJzuovUEd6RtSHOmdASrQa1--A6HBVmj8mx8+Kw@mail.gmail.com>
Date:   Sun, 28 Feb 2021 11:33:28 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Rasmus Villemoes <linux@...musvillemoes.dk>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Rob Herring <robh+dt@...nel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Arnd Bergmann <arnd@...db.de>,
        "linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>
Subject: Re: [PATCH 2/2] drivers: misc: add ripple counter driver

On Sun, Feb 28, 2021 at 11:29 AM Andy Shevchenko
<andy.shevchenko@...il.com> wrote:
>
> On Sun, Feb 28, 2021 at 11:07 AM Andy Shevchenko
> <andy.shevchenko@...il.com> wrote:
> > On Friday, February 26, 2021, Rasmus Villemoes <linux@...musvillemoes.dk> wrote:
> >>
> >> The only purpose of this driver is to serve as a consumer of the input
> >> clock, to prevent it from being disabled by clk_disable_unused().
> >
> > We have a clock API to do the same (something like marking it used or so) why do you need a driver?
>
> Example:
> https://elixir.bootlin.com/linux/latest/source/drivers/platform/x86/pmc_atom.c#L365
>
> If it's a DT based platform I think you can make it somehow work thru DT.

Okay, briefly looking at the state of affairs [1] seems like you need
to hack it into clock provider.

[1]: https://elixir.bootlin.com/linux/latest/C/ident/CLK_IS_CRITICAL

-- 
With Best Regards,
Andy Shevchenko