linux-kernel - RE: [EXT] Re: [PATCH 2/3] spi: spi-nxp-fspi: Add driver support for imx8dxl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DB6PR0402MB2758C61D8320CD0A88DC3B38E09A9@DB6PR0402MB2758.eurprd04.prod.outlook.com>
Date:   Mon, 1 Mar 2021 16:39:18 +0000
From:   Kuldeep Singh <kuldeep.singh@....com>
To:     Mark Brown <broonie@...nel.org>
CC:     "linux-spi@...r.kernel.org" <linux-spi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Ashish Kumar <ashish.kumar@....com>, Han Xu <han.xu@....com>
Subject: RE: [EXT] Re: [PATCH 2/3] spi: spi-nxp-fspi: Add driver support for
 imx8dxl

Hi Mark,

> -----Original Message-----
> From: Mark Brown <broonie@...nel.org>
> Sent: Monday, March 1, 2021 6:56 PM
> To: Kuldeep Singh <kuldeep.singh@....com>
> Cc: linux-spi@...r.kernel.org; linux-kernel@...r.kernel.org; Ashish Kumar
> <ashish.kumar@....com>; Han Xu <han.xu@....com>
> Subject: [EXT] Re: [PATCH 2/3] spi: spi-nxp-fspi: Add driver support for imx8dxl
> 
> On Mon, Mar 01, 2021 at 04:02:29PM +0530, Kuldeep Singh wrote:
> 
> > This patch is dependent on
> > https://patchwork.kernel.org/project/spi-devel-general/patch/161459304
> > 6-23832-1-git-send-email-kuldeep.singh@....com/
> 
> Please include human readable descriptions of things like commits and issues
> being discussed in e-mail in your mails, this makes them much easier for
> humans to read especially when they have no internet access.
> I do frequently catch up on my mail on flights or while otherwise travelling so
> this is even more pressing for me than just being about making things a bit
> easier to read.
> 
> That's a DT binding YAML conversion patch, why would there be a
> dependency on it?

I have converted bindings to yaml version in the patch and also added imx8dxl compatible along-with the conversion. Please see the difference in compatible entries from txt to yaml conversion[1].
Kindly let me know do I need to submit different patch for adding new compatible or ok to include in the conversion patch itself?

[1]
Documentation/devicetree/bindings/spi/nxp,spi-nxp-fspi.yaml
+properties:
+  compatible:
+    enum:
+      - nxp,lx2160a-fspi
+      - nxp,imx8qxp-fspi
+      - nxp,imx8mm-fspi
+      - nxp,imx8dxl-fspi

Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt
-Required properties:
-  - compatible : Should be "nxp,lx2160a-fspi"
-			    "nxp,imx8qxp-fspi"
-			    "nxp,imx8mm-fspi"

> 
> >
> >  drivers/spi/spi-nxp-fspi.c | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> 
> This needs a DT binding update adding the new compatible.

Please see above for comments.

Thanks
Kuldeep