linux-kernel - Re: [EXT] Re: [PATCH 2/3] spi: spi-nxp-fspi: Add driver support for imx8dxl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210301171111.GE4628@sirena.org.uk>
Date:   Mon, 1 Mar 2021 17:11:11 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Kuldeep Singh <kuldeep.singh@....com>
Cc:     "linux-spi@...r.kernel.org" <linux-spi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Ashish Kumar <ashish.kumar@....com>, Han Xu <han.xu@....com>
Subject: Re: [EXT] Re: [PATCH 2/3] spi: spi-nxp-fspi: Add driver support for
 imx8dxl

On Mon, Mar 01, 2021 at 04:39:18PM +0000, Kuldeep Singh wrote:

> > That's a DT binding YAML conversion patch, why would there be a
> > dependency on it?

> I have converted bindings to yaml version in the patch and also added imx8dxl compatible along-with the conversion. Please see the difference in compatible entries from txt to yaml conversion[1].
> Kindly let me know do I need to submit different patch for adding new compatible or ok to include in the conversion patch itself?

Your YAML binding conversion should have been a standalone patch only
doing that conversion, the new compatible should have been split out and
gone first - each patch should only do one thing as covered in
submitting-patches.rst.  As things stand the changelog for the
conversion is misleading since it doesn't mention the new compatible.

Please fix your mail client to word wrap within paragraphs at something
substantially less than 80 columns.  Doing this makes your messages much
easier to read and reply to.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)