linux-kernel - [Reoprt] Some compile warning on ppc dts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CE1E7D7EFA066443B6454A6A5063B50220CCBBE4@dggeml509-mbx.china.huawei.com>
Date:   Mon, 1 Mar 2021 02:16:55 +0000
From:   "chenjun (AM)" <chenjun102@...wei.com>
To:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        Rob Herring <robh+dt@...nel.org>,
        Michael Ellerman <mpe@...erman.id.au>,
        "Benjamin Herrenschmidt" <benh@...nel.crashing.org>,
        Paul Mackerras <paulus@...ba.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
CC:     "Xiangrui (Euler)" <rui.xiang@...wei.com>
Subject: [Reoprt] Some compile warning on ppc dts

Hi

After run the following commands
make distclean
make allmodconfig ARCH=powerpc CROSS_COMPILE=powerpc64-linux-gnu-
make oldconfig ARCH=powerpc CROSS_COMPILE=powerpc64-linux-gnu-
make -j64 ARCH=powerpc CROSS_COMPILE=powerpc64-linux-gnu-

I get some warning:
arch/powerpc/boot/dts/mpc5200b.dtsi:267.20-280.4: Warning (pci_bridge): 
/pci@...00d00: missing ranges for PCI bridg
e (or not a bridge)
arch/powerpc/boot/dts/o2dnt2.dtb: Warning (pci_device_bus_num): Failed 
prerequisite 'pci_bridge'
arch/powerpc/boot/dts/mpc5200b.dtsi:182.18-186.5: Warning 
(spi_bus_bridge): /soc5200@...00000/psc@...0: node name f
or SPI buses should be 'spi'
   also defined at arch/powerpc/boot/dts/o2d.dtsi:32.12-43.5
arch/powerpc/boot/dts/o2dnt2.dtb: Warning (spi_bus_reg): Failed 
prerequisite 'spi_bus_bridge'
..

For the problem about "node name for SPI buses should be 'spi'":
Rename the psc@...0 to spi@...0 in arch/powerpc/boot/dts/o2d.dtsi can 
fix it.
diff --git a/arch/powerpc/boot/dts/o2d.dtsi b/arch/powerpc/boot/dts/o2d.dtsi
index 6661955a2be4..cd3dc70cd72e 100644
--- a/arch/powerpc/boot/dts/o2d.dtsi
+++ b/arch/powerpc/boot/dts/o2d.dtsi
@@ -29,7 +29,7 @@ rtc@800 {
  >------>------->-------status = "disabled";
  >------>-------};
-
->------>-------psc@...0 {>----->-------// PSC1
+>------>-------spi@...0 {>----->-------// PSC1
  >------>------->-------compatible = 
"fsl,mpc5200b-psc-spi","fsl,mpc5200-psc-spi";
  >------>------->-------#address-cells = <1>;
  >------>------->-------#size-cells = <0>;
---

For the problem about "missing ranges for PCI bridge (or not a bridge)":
Ranges should be add in arch/powerpc/boot/dts/mpc5200b.dtsi.
 >-------pci: pci@...00d00 {
 >------->-------#interrupt-cells = <1>;
 >------->-------#size-cells = <2>;
 >------->-------#address-cells = <3>;
 >------->-------device_type = "pci";
 >------->-------compatible = "fsl,mpc5200b-pci","fsl,mpc5200-pci";
 >------->-------reg = <0xf0000d00 0x100>;
 >------->-------// interrupt-map-mask = need to add
 >------->-------// interrupt-map = need to add
 >------->-------clock-frequency = <0>; // From boot loader
 >------->-------interrupts = <2 8 0 2 9 0 2 10 0>;
 >------->-------bus-range = <0 0>;
 >------->-------// ranges = need to add
 >-------};
I think the ranges should be add by someone who knows the mpc5200 better.

Can anyone fix this?

-- 
Regards
Chen Jun