Message-ID: <CAOQ4uxiEih1Ojy4ncvNKV-71OMGw8964F9RQrBaxdszxHArznQ@mail.gmail.com>
Date:   Mon, 1 Mar 2021 16:58:07 +0200
From:   Amir Goldstein <amir73il@...il.com>
To:     Alejandro Colomar <alx.manpages@...il.com>
Cc:     linux-man <linux-man@...r.kernel.org>,
        Michael Kerrisk <mtk.manpages@...il.com>,
        Luis Henriques <lhenriques@...e.de>,
        Steve French <sfrench@...ba.org>,
        Greg KH <gregkh@...uxfoundation.org>,
        Anna Schumaker <anna.schumaker@...app.com>,
        Jeff Layton <jlayton@...nel.org>,
        Miklos Szeredi <miklos@...redi.hu>,
        Trond Myklebust <trond.myklebust@...merspace.com>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        "Darrick J. Wong" <darrick.wong@...cle.com>,
        Dave Chinner <dchinner@...hat.com>,
        Nicolas Boichat <drinkcat@...omium.org>,
        Ian Lance Taylor <iant@...gle.com>,
        Luis Lozano <llozano@...omium.org>,
        Andreas Dilger <adilger@...ger.ca>,
        Olga Kornievskaia <aglo@...ch.edu>,
        Christoph Hellwig <hch@...radead.org>,
        ceph-devel <ceph-devel@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        CIFS <linux-cifs@...r.kernel.org>,
        samba-technical <samba-technical@...ts.samba.org>,
        linux-fsdevel <linux-fsdevel@...r.kernel.org>,
        Linux NFS Mailing List <linux-nfs@...r.kernel.org>,
        Walter Harms <wharms@....de>
Subject: Re: [RFC v3] copy_file_range.2: Update cross-filesystem support for 5.12

On Mon, Mar 1, 2021 at 4:45 PM Alejandro Colomar <alx.manpages@...il.com> wrote:
>
> Linux 5.12 fixes a regression.
>
> Cross-filesystem (introduced in 5.3) copies were buggy.
>
> Move the statements documenting cross-fs to BUGS.
> Kernels 5.3..5.11 should be patched soon.
>
> State version information for some errors related to this.
>
> Reported-by: Luis Henriques <lhenriques@...e.de>
> Reported-by: Amir Goldstein <amir73il@...il.com>
> Related: <https://lwn.net/Articles/846403/>
> Cc: Greg KH <gregkh@...uxfoundation.org>
> Cc: Michael Kerrisk <mtk.manpages@...il.com>
> Cc: Anna Schumaker <anna.schumaker@...app.com>
> Cc: Jeff Layton <jlayton@...nel.org>
> Cc: Steve French <sfrench@...ba.org>
> Cc: Miklos Szeredi <miklos@...redi.hu>
> Cc: Trond Myklebust <trond.myklebust@...merspace.com>
> Cc: Alexander Viro <viro@...iv.linux.org.uk>
> Cc: "Darrick J. Wong" <darrick.wong@...cle.com>
> Cc: Dave Chinner <dchinner@...hat.com>
> Cc: Nicolas Boichat <drinkcat@...omium.org>
> Cc: Ian Lance Taylor <iant@...gle.com>
> Cc: Luis Lozano <llozano@...omium.org>
> Cc: Andreas Dilger <adilger@...ger.ca>
> Cc: Olga Kornievskaia <aglo@...ch.edu>
> Cc: Christoph Hellwig <hch@...radead.org>
> Cc: ceph-devel <ceph-devel@...r.kernel.org>
> Cc: linux-kernel <linux-kernel@...r.kernel.org>
> Cc: CIFS <linux-cifs@...r.kernel.org>
> Cc: samba-technical <samba-technical@...ts.samba.org>
> Cc: linux-fsdevel <linux-fsdevel@...r.kernel.org>
> Cc: Linux NFS Mailing List <linux-nfs@...r.kernel.org>
> Cc: Walter Harms <wharms@....de>
> Signed-off-by: Alejandro Colomar <alx.manpages@...il.com>
> ---
>
> v3:
>         - Don't remove some important text.
>         - Reword BUGS.
>
> ---
> Hi Amir,
>
> I covered your comments.  I may need to add something else after your
> discussion with Steve; please comment.
>
> I tried to reword BUGS so that it's as specific and understandable as I can.
> If you still find it not good enough, please comment :)
>
> Thanks,
>
> Alex
>
> ---
>  man2/copy_file_range.2 | 26 ++++++++++++++++++++++----
>  1 file changed, 22 insertions(+), 4 deletions(-)
>
> diff --git a/man2/copy_file_range.2 b/man2/copy_file_range.2
> index 611a39b80..1c0df3f74 100644
> --- a/man2/copy_file_range.2
> +++ b/man2/copy_file_range.2
> @@ -169,6 +169,9 @@ Out of memory.
>  .B ENOSPC
>  There is not enough space on the target filesystem to complete the copy.
>  .TP
> +.BR EOPNOTSUPP " (since Linux 5.12)"
> +The filesystem does not support this operation.
> +.TP
>  .B EOVERFLOW
>  The requested source or destination range is too large to represent in the
>  specified data types.
> @@ -184,10 +187,17 @@ or
>  .I fd_out
>  refers to an active swap file.
>  .TP
> -.B EXDEV
> +.BR EXDEV " (before Linux 5.3)"
> +The files referred to by
> +.IR fd_in " and " fd_out
> +are not on the same filesystem.
> +.TP
> +.BR EXDEV " (since Linux 5.12)"
>  The files referred to by
>  .IR fd_in " and " fd_out
> -are not on the same mounted filesystem (pre Linux 5.3).
> +are not on the same filesystem,
> +and the source and target filesystems are not of the same type,
> +or do not support cross-filesystem copy.
>  .SH VERSIONS
>  The
>  .BR copy_file_range ()
> @@ -200,8 +210,10 @@ Areas of the API that weren't clearly defined were clarified and the API bounds
>  are much more strictly checked than on earlier kernels.
>  Applications should target the behaviour and requirements of 5.3 kernels.
>  .PP
> -First support for cross-filesystem copies was introduced in Linux 5.3.
> -Older kernels will return -EXDEV when cross-filesystem copies are attempted.
> +Since 5.12,
> +cross-filesystem copies can be achieved
> +when both filesystems are of the same type,
> +and that filesystem implements support for it.

Maybe refer to BUGS here for pre 5.12 behavior?

>  .SH CONFORMING TO
>  The
>  .BR copy_file_range ()
> @@ -226,6 +238,12 @@ gives filesystems an opportunity to implement "copy acceleration" techniques,
>  such as the use of reflinks (i.e., two or more inodes that share
>  pointers to the same copy-on-write disk blocks)
>  or server-side-copy (in the case of NFS).
> +.SH BUGS
> +In Linux kernels 5.3 to 5.11,
> +cross-filesystem copies were supported by the kernel,
> +instead of being supported by individual filesystems.

Not so clear/accurate IMO. Maybe:

cross-filesystem copies were implemented by the kernel,
if the operation was not supported by individual filesystems.

> +However, on some virtual filesystems,
> +the call failed to copy, while still reporting success.

Thanks,
Amir.

Powered by blists - more mailing lists