linux-kernel - Re: [PATCH 34/44] tty: do not check tty_unregister

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 1 Mar 2021 22:57:10 -0800
From:   Max Filippov <jcmvbkbc@...il.com>
To:     Jiri Slaby <jslaby@...e.cz>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-serial@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
        Chris Zankel <chris@...kel.net>,
        "open list:TENSILICA XTENSA PORT (xtensa)" 
        <linux-xtensa@...ux-xtensa.org>, Jiri Kosina <jikos@...nel.org>,
        David Sterba <dsterba@...e.com>
Subject: Re: [PATCH 34/44] tty: do not check tty_unregister_driver's return value

On Mon, Mar 1, 2021 at 10:22 PM Jiri Slaby <jslaby@...e.cz> wrote:
>
> These drivers check tty_unregister_driver return value. But they don't
> handle a failure correctly (they free the driver in any case). So stop
> checking tty_unregister_driver return value and remove also the prints.
>
> In the next patch, tty_unregister_driver's return type will be switched
> to void.
>
> Signed-off-by: Jiri Slaby <jslaby@...e.cz>
> Cc: Chris Zankel <chris@...kel.net>
> Cc: Max Filippov <jcmvbkbc@...il.com>
> Cc: linux-xtensa@...ux-xtensa.org
> Cc: Jiri Kosina <jikos@...nel.org>
> Cc: David Sterba <dsterba@...e.com>
> ---
>  arch/xtensa/platforms/iss/console.c | 6 +-----
>  drivers/tty/amiserial.c             | 8 ++------
>  drivers/tty/ipwireless/tty.c        | 7 +------
>  drivers/tty/moxa.c                  | 4 +---
>  drivers/tty/serial/kgdb_nmi.c       | 4 +---
>  drivers/tty/synclink_gt.c           | 5 +----
>  6 files changed, 7 insertions(+), 27 deletions(-)

Reviewed-by: Max Filippov <jcmvbkbc@...il.com>

-- 
Thanks.
-- Max